Bugzilla – Attachment 99735 Details for
Bug 22821
Use reply-to address for item notes notifications if available to avoid being flagged as spam
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 22821: Correct to_address for issue notes
Bug-22821-Correct-toaddress-for-issue-notes.patch (text/plain), 1.84 KB, created by
Myka Kennedy Stephens
on 2020-02-28 00:30:51 UTC
(
hide
)
Description:
Bug 22821: Correct to_address for issue notes
Filename:
MIME Type:
Creator:
Myka Kennedy Stephens
Created:
2020-02-28 00:30:51 UTC
Size:
1.84 KB
patch
obsolete
>From 563f9d707a63324e3d53138486075be2eb1ae1e0 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Tue, 25 Feb 2020 07:48:31 +0000 >Subject: [PATCH] Bug 22821: Correct to_address for issue notes > >This patch updates the controller and service code to use the newly >introduced 'get_effective_email' routine from bug 22823 to obtain the >branches most appropriate email address. > >Signed-off-by: Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> >--- > opac/opac-issue-note.pl | 2 +- > opac/svc/checkout_notes | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > >diff --git a/opac/opac-issue-note.pl b/opac/opac-issue-note.pl >index 64f07fefbd..e24e80024b 100755 >--- a/opac/opac-issue-note.pl >+++ b/opac/opac-issue-note.pl >@@ -81,7 +81,7 @@ if ( $action eq 'issuenote' && C4::Context->preference('AllowCheckoutNotes') ) { > }, > ); > >- my $to_address = $branch->branchemail || $branch->branchreplyto || C4::Context->ReplytoDefault || C4::Context->preference('KohaAdminEmailAddress'); >+ my $to_address = $branch->get_effective_email; > my $reply_address = $patron->email || $patron->emailpro || $patron->B_email; > > C4::Letters::EnqueueLetter({ >diff --git a/opac/svc/checkout_notes b/opac/svc/checkout_notes >index 60b4d00bca..60adf6dccf 100755 >--- a/opac/svc/checkout_notes >+++ b/opac/svc/checkout_notes >@@ -91,7 +91,7 @@ if ($is_ajax) { > }, > ); > >- my $to_address = $branch->branchemail || $branch->branchreplyto || C4::Context->preference('ReplytoDefault') || C4::Context->preference('KohaAdminEmailAddress'); >+ my $to_address = $branch->get_effective_email; > my $reply_address = $patron->email || $patron->emailpro || $patron->B_email; > > C4::Letters::EnqueueLetter({ >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 22821
:
99559
|
99560
|
99561
|
99562
|
99563
|
99564
|
99565
|
99566
|
99732
|
99733
|
99734
|
99735
|
99908
|
99909
|
100938
|
100939
|
100940
|
100944