Attachment 99767 Details for Bug 23534 – Bug 23534: Use patron-title.inc on patron entry page

[patch] Bug 23534: Use patron-title.inc on patron entry page

Bug-23534-Use-patron-titleinc-on-patron-entry-page.patch (text/plain), 2.43 KB, created by Owen Leonard on 2020-02-28 14:55:08 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Owen Leonard

Created: 2020-02-28 14:55:08 UTC

Size: 2.43 KB

patch

obsolete

>From 7e1e4deb45ea44d7b5190cf72915817db9394e8a Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Fri, 28 Feb 2020 14:53:53 +0000
>Subject: [PATCH] Bug 23534: Use patron-title.inc on patron entry page
>
>There are a few instances where we can simplify the patron entry
>template by using the patron-title include file instead of outputting
>patron name variables one by one. This patch does so in the page title,
>page breadcrumbs, and page heading.
>
>To test, apply the patch and edit a patron record. The page title,
>breadcrumbs, and main heading should all look correct.
>
>Signed-off-by: Maryse Simard <maryse.simard@inlibro.com>
>---
> .../intranet-tmpl/prog/en/modules/members/memberentrygen.tt      | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
>index 30c18d64495..84a6a6575be 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
>@@ -16,8 +16,7 @@
>             [% ELSE %]
>                 Modify patron
>             [% END %]
>-            [% IF (firstname) %][% firstname | html %] [% END %]
>-            [% IF (surname) %][% surname | html %] [% END %]
>+            [% INCLUDE 'patron-title.inc' no_html = 1 %]
>             ([% IF categoryname -%]
>                 [%- categoryname | html -%]
>             [%- ELSE -%]
>@@ -43,8 +42,7 @@
>             &rsaquo;
>             [% IF (firstname || surname ) %]
>                 <a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% borrowernumber | uri %]">
>-                    [% IF (firstname) %][% firstname | html %] [% END %]
>-                    [% IF (surname) %][% surname | html %] [% END %]
>+                    [% INCLUDE 'patron-title.inc' %]
>                 </a>  &rsaquo;
>             [% END %]
>             <strong>
>@@ -100,8 +98,7 @@
>                             [% ELSE %]
>                                 Modify patron
>                             [% END %]
>-                            [% IF (firstname) %][% firstname | html %] [% END %]
>-                            [% IF (surname) %][% surname | html %] [% END %]
>+                            [% INCLUDE 'patron-title.inc' %]
>                             ([%IF categoryname %]
>                                 [% categoryname | html %]
>                             [% ELSE %]
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 23534: 92583 | 92662 | 99767 | 99826 | 100036