Attachment 99772 Details for Bug 24754 – Bug 24754: Set userenv for ilsdi requests

[patch] Bug 24754: Set userenv for ilsdi requests

Bug-24754-Set-userenv-for-ilsdi-requests.patch (text/plain), 1.78 KB, created by Martin Renvoize (ashimema) on 2020-02-28 15:37:54 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2020-02-28 15:37:54 UTC

Size: 1.78 KB

patch

obsolete

>From d827f6229b54d96f1c783c3e65250233ad51d04b Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Fri, 28 Feb 2020 14:46:37 +0000
>Subject: [PATCH] Bug 24754: Set userenv for ilsdi requests
>
>To test:
>1 - Enable ILSDI in systempreferences
>2 - Checkout an item to a patron
>3 - Enable Renewal logs
>4 - Ensure you will be able to renew the item several times
>5 - Open an incognito/private browser
>6 - Renew item via ilsdi:
>    http://localhost:8080/cgi-bin/koha/ilsdi.pl?service=RenewLoan&patron_id=5&item_id=1128
>7 - Check action logs - note renewal is indicated as opac
>8 - In private browser open a new tab
>9 - Sign in to staff client
>10 - Return to other tab
>11 - Refresh page to repeat renewal
>12 - Check action_logs
>13 - The second renewal indicates it was renewed via intranet by logged in staff member
>14 - Apply patch
>15 - restart_all
>16 - Ensure staff client still signed in
>17 - Repeate renewal again
>18 - Check logs, renewal now indicates opac again (as it should)
>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> opac/ilsdi.pl | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
>diff --git a/opac/ilsdi.pl b/opac/ilsdi.pl
>index 346f23e4ed..79576d84e0 100755
>--- a/opac/ilsdi.pl
>+++ b/opac/ilsdi.pl
>@@ -127,6 +127,14 @@ unless ( $cgi->param('service') ) {
>     exit 0;
> }
> 
>+# Set the userenv
>+C4::Context->_new_userenv(1);
>+C4::Context->set_userenv(
>+    undef, undef, undef, 'CRON', 'CRON', undef,
>+    undef, undef, undef, undef,  undef
>+);
>+C4::Context->interface('opac'); #FIXME 'ilsdi' should be a valid value?
>+
> # If user requested a service description, then display it
> if ( scalar $cgi->param('service') eq "Describe" and any { scalar $cgi->param('verb') eq $_ } @services ) {
>     my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 24754: 99768 | 99772 | 99773 | 99778 | 100000 | 100001 | 100006 | 100035 | 100269 | 100305 | 101094 | 101584 | 101585