Attachment 99802 Details for Bug 24746 – Bug 24746: Duplicate id in opacheader markup

[patch] Bug 24746: Duplicate id in opacheader markup

Bug-24746-Duplicate-id-in-opacheader-markup.patch (text/plain), 1.66 KB, created by Katrin Fischer on 2020-02-29 08:53:23 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2020-02-29 08:53:23 UTC

Size: 1.66 KB

patch

obsolete

>From a6eb053581f5ca1e21080b0a72038cc2920e8d89 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Thu, 27 Feb 2020 02:06:34 +0000
>Subject: [PATCH] Bug 24746: Duplicate id in opacheader markup
>
>This patch removes '<div id="opacheader">' from masthead.inc
>because the same markup is generated by koha_news_block.
>
>To reproduce the bug, make sure there is an opacheader news block
>defined. Add this to the OPACUserCSS system preference:
>
>View the main page of the OPAC. You should see two blue borders around
>the opacheader content.
>
>Apply the patch and reload the OPAC page. There should now be only one
>blue border.
>
>Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
>
>Tested whith OPACUserCSS -> #opacheader { border: 1px solid blue; padding: 1px; }
>don't know the intended value but works :)
>
>Work as described following test plan, no errors.
>---
> koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc
>index cef392338a..a27be4d487 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc
>@@ -150,9 +150,7 @@
>         [% IF ( OpacHeader ) %]
>             <div class="container-fluid">
>                 <div class="row-fluid">
>-                    <div id="opacheader">
>-                        [% PROCESS koha_news_block news => OpacHeader %]
>-                    </div>
>+                    [% PROCESS koha_news_block news => OpacHeader %]
>                 </div>
>             </div>
>         [% END %]
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 24746: 99709 | 99738 | 99802 | 99803 | 99804 | 99805