Bugzilla – Attachment 99807 Details for
Bug 24732
Make DumpTemplateVars more readable
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 24732: Set DumpTemplateVars Dumper options for Indent and Sort
Bug-24732-Set-DumpTemplateVars-Dumper-options-for-.patch (text/plain), 2.12 KB, created by
Katrin Fischer
on 2020-02-29 09:15:44 UTC
(
hide
)
Description:
Bug 24732: Set DumpTemplateVars Dumper options for Indent and Sort
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2020-02-29 09:15:44 UTC
Size:
2.12 KB
patch
obsolete
>From f1146ed1d56ed5252133c3b3e21de791ef2f64ff Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Tue, 25 Feb 2020 18:51:41 +0000 >Subject: [PATCH] Bug 24732: Set DumpTemplateVars Dumper options for Indent and > Sort > >To test: >1 - Enable sysprefs > DumpTemplateVarsOpac > DumpTemplateVarsIntranet >2 - View some pages on staff client and opac >3 - View the page source >4 - See a large mass of comments including the page vars at the top of the source >5 - Refresh page and note order of vars changes >6 - Apply patch >7 - View page source on some pages and note things are much easier to read >8 - Refresh page and note variable order does not change > >Signed-off-by: George Williams <george@nekls.org> > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > koha-tmpl/intranet-tmpl/prog/en/includes/doc-head-open.inc | 2 +- > koha-tmpl/opac-tmpl/bootstrap/en/includes/doc-head-open.inc | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/doc-head-open.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/doc-head-open.inc >index 0ccd70561d..2c493a8881 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/doc-head-open.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/doc-head-open.inc >@@ -6,7 +6,7 @@ > [% IF Koha.Preference('DumpTemplateVarsIntranet') %] > [% TRY %] > [% USE Stash %] >- [% USE Dumper %] >+ [% USE Dumper( Indent=1, SortKeys=1 ) %] > <!-- > [% FILTER replace('<!--', '<!- -') %] > [% FILTER replace('-->', '- ->') %] >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/doc-head-open.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/doc-head-open.inc >index 75ab46dfb6..03d7cf1707 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/doc-head-open.inc >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/doc-head-open.inc >@@ -6,7 +6,7 @@ > [% IF Koha.Preference('DumpTemplateVarsOpac') %] > [% TRY %] > [% USE Stash %] >- [% USE Dumper %] >+ [% USE Dumper ( Indent=1, SortKeys=1 ) %] > <!-- > [% FILTER replace('<!--', '<!- -') %] > [% FILTER replace('-->', '- ->') %] >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 24732
:
99605
|
99682
| 99807