Bugzilla – Attachment 99877 Details for
Bug 20728
Remove subroutines GetLastOrder*
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20728: Proof that there is no cheating
Bug-20728-Proof-that-there-is-no-cheating.patch (text/plain), 2.37 KB, created by
Jonathan Druart
on 2020-03-02 10:46:02 UTC
(
hide
)
Description:
Bug 20728: Proof that there is no cheating
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2020-03-02 10:46:02 UTC
Size:
2.37 KB
patch
obsolete
>From b479c3bc12b66fa6fb5008c7ab3976bc5f215f00 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Fri, 15 Mar 2019 19:24:19 -0300 >Subject: [PATCH] Bug 20728: Proof that there is no cheating > >To make sure the replacing code will acchieve the same things as the >actual one, we replace the raw SQL query with the DBIC version of it. >Then the tests will show us that they are equivalent. > >Test plan: >Apply only this patch, run the tests, confirm they pass. > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > C4/Acquisition.pm | 35 +++++++++++------------------------ > 1 file changed, 11 insertions(+), 24 deletions(-) > >diff --git a/C4/Acquisition.pm b/C4/Acquisition.pm >index e7f489fb29..e60cec2353 100644 >--- a/C4/Acquisition.pm >+++ b/C4/Acquisition.pm >@@ -1283,30 +1283,17 @@ Returns a reference-to-hash describing the last order received for a subscriptio > > sub GetLastOrderReceivedFromSubscriptionid { > my ( $subscriptionid ) = @_; >- my $dbh = C4::Context->dbh; >- my $query = qq| >- SELECT * FROM aqorders >- LEFT JOIN subscription >- ON ( aqorders.subscriptionid = subscription.subscriptionid ) >- WHERE aqorders.subscriptionid = ? >- AND aqorders.datereceived = >- ( >- SELECT MAX( aqorders.datereceived ) >- FROM aqorders >- LEFT JOIN subscription >- ON ( aqorders.subscriptionid = subscription.subscriptionid ) >- WHERE aqorders.subscriptionid = ? >- AND aqorders.datereceived IS NOT NULL >- ) >- ORDER BY ordernumber DESC >- LIMIT 1 >- |; >- my $result_set = >- $dbh->selectall_arrayref( $query, { Slice => {} }, $subscriptionid, $subscriptionid ); >- >- # result_set assumed to contain 1 match >- return $result_set->[0]; >- >+ my $lastOrderReceived = Koha::Acquisition::Orders->search( >+ { >+ subscriptionid => $subscriptionid, >+ datereceived => { '!=' => undef } >+ }, >+ { >+ order_by => >+ [ { -desc => 'datereceived' }, { -desc => 'ordernumber' } ] >+ } >+ ); >+ return $lastOrderReceived->count ? $lastOrderReceived->next->unblessed : undef; > } > > #------------------------------------------------------------# >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20728
:
86693
|
86694
|
86695
|
99655
|
99656
|
99657
|
99877
|
99878
|
99879
|
102873
|
102874
|
102875