Bugzilla – Attachment 99945 Details for
Bug 17674
Allow UI to delete serials issues in batch
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 17674: Handling of special cases
Bug-17674-Handling-of-special-cases.patch (text/plain), 3.19 KB, created by
ByWater Sandboxes
on 2020-03-02 16:17:53 UTC
(
hide
)
Description:
Bug 17674: Handling of special cases
Filename:
MIME Type:
Creator:
ByWater Sandboxes
Created:
2020-03-02 16:17:53 UTC
Size:
3.19 KB
patch
obsolete
>From f4005e83e3a8dc0e6263e106d3e03113e7b96242 Mon Sep 17 00:00:00 2001 >From: Maryse Simard <maryse.simard@inlibro.com> >Date: Fri, 21 Feb 2020 14:09:17 -0500 >Subject: [PATCH] Bug 17674: Handling of special cases > >This patch adds handling for those 2 particular cases: >1. Deleting the expected issue >2. Deleting a serial and it's item, but one item cannot be deleted > >To test: > >1.1 Create a subscription that creates items >1.2 Receive two issues >1.3 Use the new button to delete the 'Expected' issue >1.4 The issue is correctly deleted, but the new expected issue created >to replace the one which has been deleted don't have a published or >received date and is show in it's own tab. >1.5 Apply patch >1.6 Repeat steps 1.1 through 1.4 > => The new expected issue is created correctly > >2.1 Use the same serial as in 1 or repeat step 1.1 and 1.2 >2.2 Check out one of the items >2.3 Delete the corresponding serial and check box to delete items >2.4 The serial is deleted, but not the item. > => No feedback is show to the user >2.5 Apply patch >2.6 Repeat step 2.1 through 2.4 > => As before, the serial is deleted, but not the item > => This time, an error is shown to inform the user > >Signed-off-by: sonia <sonia.bouis@univ-lyon3.fr> >--- > .../intranet-tmpl/prog/en/modules/serials/serials-collection.tt | 6 ++++++ > serials/serials-collection.pl | 7 ++++--- > 2 files changed, 10 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt >index b7e02f4638..192565e88f 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt >@@ -55,6 +55,12 @@ > </div> > [% END %] > >+[% IF ( error_delitem ) %] >+ <div class="dialog alert"> >+ <p><strong>Error</strong>: one or more associated items could not be deleted at this time.</p> >+ </div> >+[% END %] >+ > [% IF ( subscriptions ) %] > <table> > [% IF ( subscriptions.size == 1 ) %] >diff --git a/serials/serials-collection.pl b/serials/serials-collection.pl >index 0977e979a0..d4b266576c 100755 >--- a/serials/serials-collection.pl >+++ b/serials/serials-collection.pl >@@ -124,14 +124,15 @@ if($op eq 'delete_confirm'){ > foreach my $serialid (@serialsid){ > my @itemnumbers = Koha::Serial::Items->search({serialid => $serialid})->get_column('itemnumber'); > foreach my $itemnumber (@itemnumbers){ >- C4::Items::DelItem({'biblionumber' => $biblionumber, 'itemnumber' => $itemnumber}); >+ my $delcheck = C4::Items::DelItemCheck($biblionumber, $itemnumber); >+ $template->param(error_delitem => 1) if $delcheck != 1; > } > } > } > for my $serialid (@serialsid){ >- ModSerialStatus($serialid,"","","","",6); >+ my $serial = Koha::Serials->find($serialid); >+ ModSerialStatus($serialid, $serial->serialseq, $serial->planneddate, $serial->publisheddate, $serial->publisheddatetext, 6, ""); > } >- print $query->redirect('/cgi-bin/koha/serials/serials-collection.pl?subscriptionid='.$subscriptionid); > } > > my $subscriptioncount; >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17674
:
57731
|
58262
|
58263
|
58264
|
60925
|
61314
|
61315
|
61316
|
66565
|
69007
|
69010
|
69011
|
69013
|
69976
|
69977
|
69978
|
69979
|
71865
|
71866
|
71867
|
71868
|
71869
|
72985
|
73032
|
73035
|
73036
|
73037
|
73038
|
73039
|
73040
|
74318
|
74359
|
74472
|
75643
|
75644
|
75645
|
75646
|
75647
|
75648
|
75649
|
77745
|
77746
|
77747
|
77748
|
77749
|
77750
|
77751
|
77861
|
77862
|
77863
|
77864
|
77865
|
77866
|
77867
|
77868
|
79415
|
79420
|
79421
|
79422
|
79423
|
79424
|
79425
|
79426
|
79427
|
79428
|
79453
|
79454
|
79455
|
79456
|
79457
|
79458
|
79459
|
79460
|
80859
|
80944
|
80955
|
82237
|
86689
|
95474
|
99434
|
99944
|
99945
|
100906
|
100907