Bugzilla – Attachment 99962 Details for
Bug 20388
Ability to add search fields from UI
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20388: Prevent user from using a search field for a mapping after removing it
Bug-20388-Prevent-user-from-using-a-search-field-f.patch (text/plain), 2.12 KB, created by
Michal Denar
on 2020-03-02 22:44:27 UTC
(
hide
)
Description:
Bug 20388: Prevent user from using a search field for a mapping after removing it
Filename:
MIME Type:
Creator:
Michal Denar
Created:
2020-03-02 22:44:27 UTC
Size:
2.12 KB
patch
obsolete
>From e1f00bd14daea4edbebf7e713a7aa97df5fc6785 Mon Sep 17 00:00:00 2001 >From: Alex Arnaud <alex.arnaud@biblibre.com> >Date: Wed, 17 Oct 2018 13:48:25 +0000 >Subject: [PATCH] Bug 20388: Prevent user from using a search field for a > mapping after removing it >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >Test plan: > > - add a search field, > - save, > - remove this search field > - check that it has been removed from the mapping lists (bottom > select). > >Signed-off-by: Björn Nylén <bjorn.nylen@ub.lu.se> >Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> >Signed-off-by: Michal Denar <black23@gmail.com> > >Signed-off-by: Michal Denar <black23@gmail.com> >--- > .../en/modules/admin/searchengine/elasticsearch/mappings.tt | 10 ++++++++++ > 1 file changed, 10 insertions(+) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/elasticsearch/mappings.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/elasticsearch/mappings.tt >index 52753a3fbf..27b8f6007a 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/elasticsearch/mappings.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/elasticsearch/mappings.tt >@@ -35,6 +35,16 @@ > } else { > $(this).parents('tr').remove(); > var line = $(this).closest("tr"); >+ >+ // We clicked delete button on search fields tab. >+ if (name = $(line).find('input[name="search_field_name"]').val()) { >+ // Prevent user from using a search field for a mapping >+ // after removing it without saving. >+ $('select[data-id="mapping_search_field_name"]').each(function( index, element) { >+ $(element).find('option[value="' + name + '"]').remove(); >+ }); >+ } >+ > var search_field_name = $(line).find('input[name="mapping_search_field_name"]').val(); > var mappings = $('input[name="mapping_search_field_name"][type="hidden"][value="' + search_field_name + '"]'); > if (mappings.length == 0) { >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20388
:
73158
|
73165
|
73167
|
73476
|
73626
|
73627
|
73629
|
73681
|
73682
|
73918
|
73919
|
73940
|
73943
|
73944
|
73945
|
73946
|
74261
|
74718
|
74719
|
78658
|
78659
|
80709
|
86912
|
87196
|
87197
|
87198
|
87199
|
87201
|
87202
|
87203
|
87204
|
88075
|
88079
|
88080
|
88081
|
88082
|
88083
|
89117
|
89118
|
89121
|
89733
|
89894
|
90517
|
90518
|
90519
|
90520
|
90521
|
90522
|
90523
|
90524
|
98011
|
98012
|
98013
|
98014
|
98015
|
98016
|
98017
|
98018
|
99960
|
99961
|
99962
|
99963
|
99964
|
99965
|
99966
|
99967
|
119296
|
119317
|
119318
|
120104
|
163449
|
163450
|
163451
|
163452
|
163460
|
163461
|
163462
|
163463
|
164529
|
164530
|
164531
|
164532
|
164533
|
164534
|
164535
|
164789
|
164790
|
164791
|
164792
|
164793