Bugzilla – Attachment 99990 Details for
Bug 24608
Allow modification of checkout due date
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 24608: (follow-up) Buttons should be buttons
Bug-24608-follow-up-Buttons-should-be-buttons.patch (text/plain), 2.27 KB, created by
PTFS Europe Sandboxes
on 2020-03-03 11:55:55 UTC
(
hide
)
Description:
Bug 24608: (follow-up) Buttons should be buttons
Filename:
MIME Type:
Creator:
PTFS Europe Sandboxes
Created:
2020-03-03 11:55:55 UTC
Size:
2.27 KB
patch
obsolete
>From 8e6d95cfe28043e1731eaf8ddb53e94af1d1db4d Mon Sep 17 00:00:00 2001 >From: Andrew Isherwood <andrew.isherwood@ptfs-europe.com> >Date: Tue, 3 Mar 2020 09:34:55 +0000 >Subject: [PATCH] Bug 24608: (follow-up) Buttons should be buttons > >No idea why I used <a> elements for the Edit buttons. But the 'disabled' >attribute has no effect on <a> elements, which leads to all sorts of >problems when you have disabled buttons that are not disabled. > >Switched to <button> elements. > >Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> >--- > koha-tmpl/intranet-tmpl/prog/js/checkouts.js | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/checkouts.js b/koha-tmpl/intranet-tmpl/prog/js/checkouts.js >index 6236b74f61..8a3d3c72d0 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/checkouts.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/checkouts.js >@@ -271,7 +271,7 @@ $(document).ready(function() { > due = "<div data-issue_id='"+ oObj.issue_id + "' style='white-space:nowrap'><span id='date_due_" + oObj.itemnumber + "' class='date_due'>" + due + "</span>"; > > if (canEditDueDates) { >- due += " <a href='#' class='edit_due_date_btn btn btn-default btn-xs'><i class='fa fa-pencil'></i> " + EDIT + "</a></div>"; >+ due += " <button type='button' class='edit_due_date_btn btn btn-default btn-xs'><i class='fa fa-pencil'></i> " + EDIT + "</a></div>"; > } > > if ( oObj.lost && oObj.claims_returned ) { >@@ -1099,7 +1099,7 @@ $(document).ready(function() { > var current = date_display.text(); > date_display.hide(); > $(this).closest('div').append('<input style="max-width:10em" type="text" id="due_date_select" value="' + current + '"></input>' + >- '<a style="margin-left:1.5em" href="#" class="save_due_date_btn btn btn-default btn-xs"><i class="fa fa-save"></i> ' + SAVE + '</a>'); >+ '<button type="button" style="margin-left:1.5em" class="save_due_date_btn btn btn-default btn-xs"><i class="fa fa-save"></i> ' + SAVE + '</button>'); > $(this).hide(); > $("#due_date_select").datetimepicker({ > onClose: function(dateText, inst) { >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 24608
:
98902
|
98903
|
98908
|
98909
|
98914
|
98915
|
98931
|
98932
|
99240
|
99880
|
99979
|
99986
|
99987
|
99988
|
99989
|
99990
|
126195
|
126196
|
126197
|
126198
|
126201