From 7cae1e569bf5c7cea6a81c28c5b78e7c4d8e53e4 Mon Sep 17 00:00:00 2001
From: Agustin Moyano <agustinmoyano@theke.io>
Date: Sun, 9 Feb 2020 17:53:55 -0300
Subject: [PATCH] Bug 20936: Add OPACHoldsHistory syspref

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
---
 .../data/mysql/atomicupdate/bug-20936.perl      | 17 +++++++++++++++++
 installer/data/mysql/sysprefs.sql               |  1 +
 .../prog/en/modules/admin/preferences/opac.pref |  6 ++++++
 3 files changed, 24 insertions(+)
 create mode 100644 installer/data/mysql/atomicupdate/bug-20936.perl

diff --git a/installer/data/mysql/atomicupdate/bug-20936.perl b/installer/data/mysql/atomicupdate/bug-20936.perl
new file mode 100644
index 0000000000..b9173fcde4
--- /dev/null
+++ b/installer/data/mysql/atomicupdate/bug-20936.perl
@@ -0,0 +1,17 @@
+$DBversion = 'XXX'; # will be replaced by the RM
+if( CheckVersion( $DBversion ) ) {
+    # you can use $dbh here like:
+    $dbh->do(qq{
+        INSERT IGNORE INTO systempreferences ( `variable`, `value`, `options`, `explanation`, `type` ) VALUES
+        ('OPACHoldsHistory','1','','If ON, enables display of Patron Holds History in OPAC','YesNo')
+    });
+
+    # or perform some test and warn
+    # if( !column_exists( 'biblio', 'biblionumber' ) ) {
+    #    warn "There is something wrong";
+    # }
+
+    # Always end with this (adjust the bug info)
+    SetVersion( $DBversion );
+    print "Upgrade to $DBversion done (Bug 20936 - Add OPACHoldsHistory preferences)\n";
+}
diff --git a/installer/data/mysql/sysprefs.sql b/installer/data/mysql/sysprefs.sql
index 49b6633f08..87be6a16c6 100644
--- a/installer/data/mysql/sysprefs.sql
+++ b/installer/data/mysql/sysprefs.sql
@@ -387,6 +387,7 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, `
 ('OpacHiddenItemsExceptions','',NULL,'List of borrower categories, separated by |, that can see items otherwise hidden by OpacHiddenItems','Textarea'),
 ('OpacHighlightedWords','1','','If Set, then queried words are higlighted in OPAC','YesNo'),
 ('OPACHoldingsDefaultSortField','first_column','first_column|homebranch|holdingbranch','Default sort field for the holdings table at the OPAC','choice'),
+('OPACHoldsHistory','1','','If ON, enables display of Patron Holds History in OPAC','YesNo'),
 ('OPACHoldsIfAvailableAtPickup','1','','Allow to pickup up holds at libraries where the item is available','YesNo'),
 ('OPACHoldsIfAvailableAtPickupExceptions','','','List the patron categories not affected by OPACHoldsIfAvailableAtPickup if off','Free'),
 ('OpacHoldNotes','0','','Show hold notes on OPAC','YesNo'),
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
index 9c9b2b7f00..254f832c98 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
@@ -708,6 +708,12 @@ OPAC:
                   yes: Allow
                   no: "Don't allow"
             - patrons to see what books they have checked out in the past.
+        -
+            - pref: OPACHoldsHistory
+              choices:
+                  yes: Allow
+                  no: "Don't allow"
+            - patrons to see what books they have place holds in the past.
         -
             - pref: EnableOpacSearchHistory
               default: 0
-- 
2.25.0