From 8bb0cd5297c0b95cf0d75d46a69d2d6391f12cd5 Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Fri, 6 Mar 2020 15:06:02 +0000 Subject: [PATCH] Bug 23433: Make consistent use of patron-title.inc in hold confirmation dialogs Use of patron-title.inc on the checkin page is inconsistent, resulting in patron names being displayed differently under different circumstances. This patch makes it more consistent. To test, apply the patch and check in items with the following statuses: - On hold for a patron at your library - On hold for a patron not at your library - On hold and already marked 'Waiting' - On hold while HoldsAutoFill preference is enabled - An item which has been marked with a LOST status in the 'ClaimReturnedLostValue' system preference. --- koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt | 16 +++++----------- 1 file changed, 5 insertions(+), 11 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt index 29818882c91..b19b56a4c62 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt @@ -164,9 +164,7 @@ [% FOREACH rc IN ReturnClaims %] [% SET patron = rc.patron %]
  • - - [% patron.firstname | html %] [% patron.surname | html %] - + [% INCLUDE 'patron-title.inc' hide_patron_infos_if_needed=1 invert_name=1 %]
  • [% END %] @@ -185,9 +183,7 @@ [% IF return_date_was_overriden && Borrowers.IsDebarred( borrower ) %]

    - - [% patron.firstname | html %] [% patron.surname | html %] - + [% INCLUDE 'patron-title.inc' hide_patron_infos_if_needed=1 invert_name=1 %] is restricted. Please verify this patron should still be restricted.

    @@ -419,7 +415,7 @@

    Hold for: