Bugzilla – Attachment 100277 Details for
Bug 23433
Make consistent use of patron-title.inc in hold confirmation dialogs
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23433: Make consistent use of patron-title.inc in hold confirmation dialogs
Bug-23433-Make-consistent-use-of-patron-titleinc-i.patch (text/plain), 5.37 KB, created by
Owen Leonard
on 2020-03-06 15:47:54 UTC
(
hide
)
Description:
Bug 23433: Make consistent use of patron-title.inc in hold confirmation dialogs
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2020-03-06 15:47:54 UTC
Size:
5.37 KB
patch
obsolete
>From 8bb0cd5297c0b95cf0d75d46a69d2d6391f12cd5 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Fri, 6 Mar 2020 15:06:02 +0000 >Subject: [PATCH] Bug 23433: Make consistent use of patron-title.inc in hold > confirmation dialogs > >Use of patron-title.inc on the checkin page is inconsistent, resulting >in patron names being displayed differently under different >circumstances. This patch makes it more consistent. > >To test, apply the patch and check in items with the following statuses: > > - On hold for a patron at your library > - On hold for a patron not at your library > - On hold and already marked 'Waiting' > - On hold while HoldsAutoFill preference is enabled > - An item which has been marked with a LOST status in the > 'ClaimReturnedLostValue' system preference. >--- > koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt | 16 +++++----------- > 1 file changed, 5 insertions(+), 11 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >index 29818882c91..b19b56a4c62 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >@@ -164,9 +164,7 @@ > [% FOREACH rc IN ReturnClaims %] > [% SET patron = rc.patron %] > <li> >- <a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% patron.borrowernumber | uri %]"> >- [% patron.firstname | html %] [% patron.surname | html %] >- </a> >+ [% INCLUDE 'patron-title.inc' hide_patron_infos_if_needed=1 invert_name=1 %] > </li> > [% END %] > </ul> >@@ -185,9 +183,7 @@ > [% IF return_date_was_overriden && Borrowers.IsDebarred( borrower ) %] > <div id="restricted_backdated" class="dialog message"> > <h3> >- <a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% patron.borrowernumber | uri %]"> >- [% patron.firstname | html %] [% patron.surname | html %] >- </a> >+ [% INCLUDE 'patron-title.inc' hide_patron_infos_if_needed=1 invert_name=1 %] > is restricted. Please verify this patron should still be restricted. > </h3> > </div> >@@ -419,7 +415,7 @@ > <h4>Hold for:</h4> > <ul> > <li> >- [% INCLUDE 'patron-title.inc' patron=patron hide_patron_infos_if_needed=1 link_to="circulation_reserves" %] >+ [% INCLUDE 'patron-title.inc' patron=patron hide_patron_infos_if_needed=1 invert_name=1 link_to="circulation_reserves" %] > <span class="patron-category"> - [% patron.category.description | html %]</span> > </li> > [% INCLUDE display_holdpatron_address %] >@@ -577,7 +573,7 @@ > <h5>Hold for:</h5> > <ul> > <li> >- [% INCLUDE 'patron-title.inc' patron=patron hide_patron_infos_if_needed=1 link_to="circulation_reserves" %] >+ [% INCLUDE 'patron-title.inc' patron=patron hide_patron_infos_if_needed=1 invert_name=1 link_to="circulation_reserves" %] > <span class="patron-category"> - [% patron.category.description | html %]</span> > </li> > >@@ -855,9 +851,7 @@ > </td> > <td class="ci-patron"> > [% IF ( riloo.duedate ) %] >- <a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% riloo.patron.borrowernumber | uri %]"> >- [% riloo.patron.surname | html %], [% riloo.patron.firstname | html %] ([% riloo.patron.category.description | html %]) >- </a> >+ [% INCLUDE 'patron-title.inc' patron=riloo.patron hide_patron_infos_if_needed=1 invert_name=1 %] > [% IF riloo.borissuescount %] > <span class="results_summary nowrap"> > <span class="label">Checkouts:</span> >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23433
:
92032
|
100277
|
100916
|
104028
|
104105
|
104114
|
104251