From 35042bdb2bb19681cdc1586e7f2227e6cf32b331 Mon Sep 17 00:00:00 2001 From: Andrew Fuerste-Henry Date: Wed, 11 Mar 2020 00:15:58 +0000 Subject: [PATCH] Bug 24378: Change wording of auto_renewals notice in updatedatabase Test plan: - install patch - update databse - confirm changes to notice name and wording --- .../mysql/atomicupdate/reword_auto_renewals.perl | 35 +++++++++++++++++++ installer/data/mysql/updatedatabase.pl | 40 +++++++++++----------- 2 files changed, 55 insertions(+), 20 deletions(-) create mode 100644 installer/data/mysql/atomicupdate/reword_auto_renewals.perl diff --git a/installer/data/mysql/atomicupdate/reword_auto_renewals.perl b/installer/data/mysql/atomicupdate/reword_auto_renewals.perl new file mode 100644 index 0000000000..8c5d286fa6 --- /dev/null +++ b/installer/data/mysql/atomicupdate/reword_auto_renewals.perl @@ -0,0 +1,35 @@ +$DBversion = 'XXX'; # will be replaced by the RM +if( CheckVersion( $DBversion ) ) { + # you can use $dbh here like: + $dbh->do( q{ + INSERT INTO letter (module, code, name, title, content, message_transport_type) VALUES ('circulation', 'AUTO_RENEWALS', 'Notification of automatic renewal', 'Automatic renewal notice', + "Dear [% borrower.firstname %] [% borrower.surname %], + [% IF checkout.auto_renew_error %] + The following item, [% biblio.title %], has not been renewed because: + [% IF checkout.auto_renew_error == 'too_many' %] + You have reached the maximum number of checkouts possible. + [% ELSIF checkout.auto_renew_error == 'on_reserve' %] + This item is on hold for another patron. + [% ELSIF checkout.auto_renew_error == 'restriction' %] + You are currently restricted. + [% ELSIF checkout.auto_renew_error == 'overdue' %] + You have overdue items. + [% ELSIF checkout.auto_renew_error == 'auto_too_late' %] + It\'s too late to renew this item. + [% ELSIF checkout.auto_renew_error == 'auto_too_much_oweing' %] + Your total unpaid fines are too high. + [% END %] + [% ELSE %] + The following item, [% biblio.title %], has correctly been renewed and is now due on [% checkout.date_due %] + [% END %]", 'email'); + }); + + # or perform some test and warn + # if( !column_exists( 'biblio', 'biblionumber' ) ) { + # warn "There is something wrong"; + # } + + # Always end with this (adjust the bug info) + SetVersion( $DBversion ); + print "Upgrade to $DBversion done (Bug 24378 - Change wording on AUTO_RENEWALS notice in updatedatabase)\n"; +} diff --git a/installer/data/mysql/updatedatabase.pl b/installer/data/mysql/updatedatabase.pl index 26c254206d..247870607b 100755 --- a/installer/data/mysql/updatedatabase.pl +++ b/installer/data/mysql/updatedatabase.pl @@ -14438,26 +14438,26 @@ if( CheckVersion( $DBversion ) ) { } $dbh->do(q{ - INSERT INTO letter (module, code, name, title, content, message_transport_type) VALUES ('circulation', 'AUTO_RENEWALS', 'notification on auto renewing', 'Auto renewals', -"Dear [% borrower.firstname %] [% borrower.surname %], -[% IF checkout.auto_renew_error %] -The following item [% biblio.title %] has not been correctly renewed -[% IF checkout.auto_renew_error == 'too_many' %] -You have reach the maximum of checkouts possible. -[% ELSIF checkout.auto_renew_error == 'on_reserve' %] -This item is on hold for another patron. -[% ELSIF checkout.auto_renew_error == 'restriction' %] -You are currently restricted. -[% ELSIF checkout.auto_renew_error == 'overdue' %] -You have overdues. -[% ELSIF checkout.auto_renew_error == 'auto_too_late' %] -It\'s too late to renew this checkout. -[% ELSIF checkout.auto_renew_error == 'auto_too_much_oweing' %] -You have too much unpaid fines. -[% END %] -[% ELSE %] -The following item [% biblio.title %] has correctly been renewed and is now due [% checkout.date_due %] -[% END %]", 'email'); + INSERT INTO letter (module, code, name, title, content, message_transport_type) VALUES ('circulation', 'AUTO_RENEWALS', 'Notification of automatic renewal', 'Automatic renewal notice', + "Dear [% borrower.firstname %] [% borrower.surname %], + [% IF checkout.auto_renew_error %] + The following item, [% biblio.title %], has not been renewed because: + [% IF checkout.auto_renew_error == 'too_many' %] + You have reached the maximum number of checkouts possible. + [% ELSIF checkout.auto_renew_error == 'on_reserve' %] + This item is on hold for another patron. + [% ELSIF checkout.auto_renew_error == 'restriction' %] + You are currently restricted. + [% ELSIF checkout.auto_renew_error == 'overdue' %] + You have overdue items. + [% ELSIF checkout.auto_renew_error == 'auto_too_late' %] + It\'s too late to renew this item. + [% ELSIF checkout.auto_renew_error == 'auto_too_much_oweing' %] + Your total unpaid fines are too high. + [% END %] + [% ELSE %] + The following item, [% biblio.title %], has correctly been renewed and is now due on [% checkout.date_due %] + [% END %]", 'email'); }); SetVersion( $DBversion ); -- 2.11.0