From 16419bbed8ef14bc087c57e076270dc39474d80c Mon Sep 17 00:00:00 2001 From: Nick Clemens Date: Thu, 12 Mar 2020 07:52:00 -0400 Subject: [PATCH] Bug 24298: Update test count and use build_sample_item Signed-off-by: Nick Clemens --- t/db_dependent/Items.t | 48 ++++++++++++++---------------------------------- 1 file changed, 14 insertions(+), 34 deletions(-) diff --git a/t/db_dependent/Items.t b/t/db_dependent/Items.t index f72315dd83..da4b6f0400 100755 --- a/t/db_dependent/Items.t +++ b/t/db_dependent/Items.t @@ -33,7 +33,7 @@ use Koha::AuthorisedValues; use t::lib::Mocks; use t::lib::TestBuilder; -use Test::More tests => 15; +use Test::More tests => 16; use Test::Warn; @@ -117,29 +117,21 @@ subtest 'ModItem tests' => sub { $schema->storage->txn_begin; my $builder = t::lib::TestBuilder->new; - my $item = $builder->build({ - source => 'Item', - value => { - itemlost => 0, - damaged => 0, - withdrawn => 0, - itemlost_on => undef, - damaged_on => undef, - withdrawn_on => undef, - } - }); + my $item = $builder->build_sample_item(); my @fields = qw( itemlost withdrawn damaged ); for my $field (@fields) { - $item->{$field} = 1; - ModItem( $item, $item->{biblionumber}, $item->{itemnumber} ); - my $post_mod_item = Koha::Items->find({ itemnumber => $item->{itemnumber} })->unblessed; - is( output_pref({ str => $post_mod_item->{$field."_on"}, dateonly => 1 }), output_pref({ dt => dt_from_string(), dateonly => 1 }), "When updating $field, $field"."_on is updated" ); - - $item->{$field} = 0; - ModItem( $item, $item->{biblionumber}, $item->{itemnumber} ); - $post_mod_item = Koha::Items->find({ itemnumber => $item->{itemnumber} })->unblessed; - is( $post_mod_item->{$field."_on"}, undef, "When clearing $field, $field"."_on is cleared" ); + my $field_on = $field."_on"; + + $item->$field(1); + ModItem( $item->unblessed, $item->biblionumber, $item->itemnumber ); + $item->discard_changes; + is( output_pref({ str => $item->$field_on, dateonly => 1 }), output_pref({ dt => dt_from_string(), dateonly => 1 }), "When updating $field, $field_on is updated" ); + + $item->$field(0); + ModItem( $item->unblessed, $item->biblionumber, $item->itemnumber ); + $item->discard_changes; + is( $item->$field_on, undef, "When clearing $field, $field_on is cleared" ); } $schema->storage->txn_rollback; @@ -152,19 +144,7 @@ subtest 'ModItemTransfer tests' => sub { $schema->storage->txn_begin; my $builder = t::lib::TestBuilder->new; - my $item = $builder->build_object( - { - class => 'Koha::Items', - value => { - itemlost => 0, - damaged => 0, - withdrawn => 0, - itemlost_on => undef, - damaged_on => undef, - withdrawn_on => undef, - } - } - )->store; + my $item = $builder->build_sample_item(); my $library1 = $builder->build( { -- 2.11.0