From 47b3fd0ec15bcdd380bc040d749027fe1628564a Mon Sep 17 00:00:00 2001 From: Marcel de Rooy Date: Wed, 18 Mar 2020 13:54:52 +0000 Subject: [PATCH] Bug 24892: Resolve uninitialized warns from opac-memberentry Content-Type: text/plain; charset=utf-8 Especially line 500 (current master). Use of uninitialized value $new_data{"sort2"} in string eq at /usr/share/koha/opac/opac-memberentry.pl line 500. Use of uninitialized value in string eq at /usr/share/koha/opac/opac-memberentry.pl line 500. Trivial fix. Test plan: Do not apply, update from opac memberentry. Check warns in log. Apply patch, update again. Less warns? Signed-off-by: Marcel de Rooy --- opac/opac-memberentry.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/opac/opac-memberentry.pl b/opac/opac-memberentry.pl index 391a78f8e0..f535755122 100755 --- a/opac/opac-memberentry.pl +++ b/opac/opac-memberentry.pl @@ -497,7 +497,7 @@ sub DelUnchangedFields { foreach my $key ( keys %new_data ) { - if ( ($current_data->{$key} eq $new_data{$key}) || $hidden_fields->{$key} ) { + if ( !defined($new_data{$key}) && !defined($current_data->{$key}) || $current_data->{$key} eq $new_data{$key} || $hidden_fields->{$key} ) { delete $new_data{$key}; } } -- 2.11.0