From 7f6be80858d62f3609b6bf3d5e213987535a2ff9 Mon Sep 17 00:00:00 2001 From: Kyle M Hall Date: Mon, 3 Feb 2020 07:56:37 -0500 Subject: [PATCH] Bug 24566: UpdateItemLocationOnCheckin triggers SIP2 alert flag, even with checked_in_ok enabled If UpdateItemLocationOnCheckin, it triggers an alert flag but cannot be acted on in the same way as LocalUse and thus should be removed in the same fashion. Test Plan: 1) Enable UpdateItemLocationOnCheckin and set it up to trigger at checkin for an item 2) Return that item via SIP2 3) Note the alert flag is set 4) Apply this patch 5) Repeat steps 1 and 2 6) The alert flag should not be set Signed-off-by: Kyle M Hall Signed-off-by: Kevin Cook Signed-off-by: Martin Renvoize --- C4/SIP/ILS/Transaction/Checkin.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/C4/SIP/ILS/Transaction/Checkin.pm b/C4/SIP/ILS/Transaction/Checkin.pm index 08aaddb7ca..ac92fa6c50 100644 --- a/C4/SIP/ILS/Transaction/Checkin.pm +++ b/C4/SIP/ILS/Transaction/Checkin.pm @@ -72,6 +72,7 @@ sub do_checkin { my ($return, $messages, $issue, $borrower) = AddReturn($barcode, $branch, undef, dt_from_string($return_date)); if ( $checked_in_ok ) { + delete $messages->{ItemLocationUpdated}; delete $messages->{NotIssued}; delete $messages->{LocalUse}; $return = 1 unless keys %$messages; -- 2.20.1