Bugzilla – Attachment 10120 Details for
Bug 7810
C4/Auth.pm - on plack restart session is undefined
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 7810 - C4/Auth.pm - on plack restart session is undefined
Bug-7810---C4Authpm---on-plack-restart-session-is-.patch (text/plain), 1.27 KB, created by
Jared Camins-Esakov
on 2012-06-10 14:36:44 UTC
(
hide
)
Description:
Bug 7810 - C4/Auth.pm - on plack restart session is undefined
Filename:
MIME Type:
Creator:
Jared Camins-Esakov
Created:
2012-06-10 14:36:44 UTC
Size:
1.27 KB
patch
obsolete
>From 954c373ed3238ec0228b67c5d45fe9f1d46a1038 Mon Sep 17 00:00:00 2001 >From: Dobrica Pavlinusic <dpavlin@rot13.org> >Date: Fri, 23 Mar 2012 09:54:25 +0100 >Subject: [PATCH] Bug 7810 - C4/Auth.pm - on plack restart session is undefined >Content-Type: text/plain; charset="UTF-8" > >So we shouldn't try to delete it. This produces application error >instead of redirection to login page. > >I had similar problems with CGI, especially when session in browser >is still active, and one on filesystem or database is already expired. > >Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> >Solved the problem when my Plack installation started acting up due to >stale cookies. >--- > C4/Auth.pm | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > >diff --git a/C4/Auth.pm b/C4/Auth.pm >index ffee1bb..d7025b1 100644 >--- a/C4/Auth.pm >+++ b/C4/Auth.pm >@@ -689,7 +689,7 @@ sub checkauth { > elsif ( $lasttime < time() - $timeout ) { > # timed logout > $info{'timed_out'} = 1; >- $session->delete(); >+ $session->delete() if $session; > C4::Context->_unset_userenv($sessionID); > #_session_log(sprintf "%20s from %16s logged out at %30s (inactivity).\n", $userid,$ip,(strftime "%c",localtime)); > $userid = undef; >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 7810
:
8553
| 10120