View | Details | Raw Unified | Return to bug 23463
Collapse All | Expand All

(-)a/t/db_dependent/Circulation/Returns.t (-1 / +1 lines)
Lines 70-76 Koha::CirculationRules->set_rule( Link Here
70
70
71
subtest "AddReturn logging on statistics table (item-level_itypes=1)" => sub {
71
subtest "AddReturn logging on statistics table (item-level_itypes=1)" => sub {
72
72
73
    plan tests => 4;
73
    plan tests => 3;
74
74
75
    # Set item-level item types
75
    # Set item-level item types
76
    t::lib::Mocks::mock_preference( "item-level_itypes", 1 );
76
    t::lib::Mocks::mock_preference( "item-level_itypes", 1 );
(-)a/t/db_dependent/Holds.t (-30 / +32 lines)
Lines 827-851 subtest 'CanItemBeReserved / branch_not_in_hold_group' => sub { Link Here
827
827
828
    # Create 3 biblios with items
828
    # Create 3 biblios with items
829
    my $biblio_1 = $builder->build_sample_biblio({ itemtype => $itemtype1->itemtype });
829
    my $biblio_1 = $builder->build_sample_biblio({ itemtype => $itemtype1->itemtype });
830
    my ( undef, undef, $itemnumber_1 ) = AddItem(
830
    my $item_1   = $builder->build_sample_item(
831
        {   homebranch    => $library1->branchcode,
831
        {
832
            holdingbranch => $library1->branchcode
832
            biblionumber => $biblio_1->biblionumber,
833
        },
833
            library      => $library1->branchcode
834
        $biblio_1->biblionumber
834
        }
835
    );
835
    );
836
    my $biblio_2 = $builder->build_sample_biblio({ itemtype => $itemtype2->itemtype });
836
    my $biblio_2 = $builder->build_sample_biblio({ itemtype => $itemtype2->itemtype });
837
    my ( undef, undef, $itemnumber_2 ) = AddItem(
837
    my $item_2   = $builder->build_sample_item(
838
        {   homebranch    => $library2->branchcode,
838
        {
839
            holdingbranch => $library2->branchcode
839
            biblionumber => $biblio_2->biblionumber,
840
        },
840
            library      => $library2->branchcode
841
        $biblio_2->biblionumber
841
        }
842
    );
842
    );
843
    my $itemnumber_2 = $item_2->itemnumber;
843
    my $biblio_3 = $builder->build_sample_biblio({ itemtype => $itemtype1->itemtype });
844
    my $biblio_3 = $builder->build_sample_biblio({ itemtype => $itemtype1->itemtype });
844
    my ( undef, undef, $itemnumber_3 ) = AddItem(
845
    my $item_3   = $builder->build_sample_item(
845
        {   homebranch    => $library1->branchcode,
846
        {
846
            holdingbranch => $library1->branchcode
847
            biblionumber => $biblio_3->biblionumber,
847
        },
848
            library      => $library1->branchcode
848
        $biblio_3->biblionumber
849
        }
849
    );
850
    );
850
851
851
    # Test 1: Patron 3 can place hold
852
    # Test 1: Patron 3 can place hold
Lines 1047-1071 subtest 'CanItemBeReserved / pickup_not_in_hold_group' => sub { Link Here
1047
1048
1048
    # Create 3 biblios with items
1049
    # Create 3 biblios with items
1049
    my $biblio_1 = $builder->build_sample_biblio({ itemtype => $itemtype1->itemtype });
1050
    my $biblio_1 = $builder->build_sample_biblio({ itemtype => $itemtype1->itemtype });
1050
    my ( undef, undef, $itemnumber_1 ) = AddItem(
1051
    my $item_1   = $builder->build_sample_item(
1051
        {   homebranch    => $library1->branchcode,
1052
        {
1052
            holdingbranch => $library1->branchcode
1053
            biblionumber => $biblio_1->biblionumber,
1053
        },
1054
            library      => $library1->branchcode
1054
        $biblio_1->biblionumber
1055
        }
1055
    );
1056
    );
1056
    my $biblio_2 = $builder->build_sample_biblio({ itemtype => $itemtype2->itemtype });
1057
    my $biblio_2 = $builder->build_sample_biblio({ itemtype => $itemtype2->itemtype });
1057
    my ( undef, undef, $itemnumber_2 ) = AddItem(
1058
    my $item_2   = $builder->build_sample_item(
1058
        {   homebranch    => $library2->branchcode,
1059
        {
1059
            holdingbranch => $library2->branchcode
1060
            biblionumber => $biblio_2->biblionumber,
1060
        },
1061
            library      => $library2->branchcode
1061
        $biblio_2->biblionumber
1062
        }
1062
    );
1063
    );
1064
    my $itemnumber_2 = $item_2->itemnumber;
1063
    my $biblio_3 = $builder->build_sample_biblio({ itemtype => $itemtype1->itemtype });
1065
    my $biblio_3 = $builder->build_sample_biblio({ itemtype => $itemtype1->itemtype });
1064
    my ( undef, undef, $itemnumber_3 ) = AddItem(
1066
    my $item_3   = $builder->build_sample_item(
1065
        {   homebranch    => $library1->branchcode,
1067
        {
1066
            holdingbranch => $library1->branchcode
1068
            biblionumber => $biblio_3->biblionumber,
1067
        },
1069
            library      => $library1->branchcode
1068
        $biblio_3->biblionumber
1070
        }
1069
    );
1071
    );
1070
1072
1071
    # Test 1: Patron 3 can place hold
1073
    # Test 1: Patron 3 can place hold
(-)a/t/db_dependent/Members/GetAllIssues.t (-2 / +2 lines)
Lines 60-66 my $itemnumber1 = $builder->build_sample_item({ biblionumber => $biblionumber1, Link Here
60
my $itemnumber2 = $builder->build_sample_item({ biblionumber => $biblionumber1, barcode => '0102', %item_infos })->itemnumber;
60
my $itemnumber2 = $builder->build_sample_item({ biblionumber => $biblionumber1, barcode => '0102', %item_infos })->itemnumber;
61
61
62
my ($biblionumber2) = AddBiblio( MARC::Record->new, '' );
62
my ($biblionumber2) = AddBiblio( MARC::Record->new, '' );
63
my $itemnumber2 = $builder->build_sample_item({ biblionumber => $biblionumber2, barcode => '0202', %item_infos })->itemnumber;
63
my $itemnumber3 = $builder->build_sample_item({ biblionumber => $biblionumber2, barcode => '0202', %item_infos })->itemnumber;
64
64
65
my $borrowernumber1 =
65
my $borrowernumber1 =
66
  Koha::Patron->new({ categorycode => $categorycode, branchcode => $branchcode })->store->borrowernumber;
66
  Koha::Patron->new({ categorycode => $categorycode, branchcode => $branchcode })->store->borrowernumber;
Lines 100-106 is( $issues->[1]->{itemnumber}, $itemnumber2, '' ); Link Here
100
$issues = C4::Members::GetAllIssues($borrowernumber2);
100
$issues = C4::Members::GetAllIssues($borrowernumber2);
101
is( @$issues, 0, 'GetAllIssues returns the correct number of elements' );
101
is( @$issues, 0, 'GetAllIssues returns the correct number of elements' );
102
102
103
AddIssue( $borrower2, '0203' );
103
AddIssue( $borrower2, '0202' );
104
$issues = C4::Members::GetAllIssues($borrowernumber1);
104
$issues = C4::Members::GetAllIssues($borrowernumber1);
105
is( @$issues, 2, 'GetAllIssues returns the correct number of elements' );
105
is( @$issues, 2, 'GetAllIssues returns the correct number of elements' );
106
is( $issues->[0]->{itemnumber}, $itemnumber1, '' );
106
is( $issues->[0]->{itemnumber}, $itemnumber1, '' );
(-)a/t/db_dependent/Reserves.t (-2 / +1 lines)
Lines 404-410 is($new_count, $hold_notice_count + 1, 'patron not notified a second time (bug 1 Link Here
404
404
405
# avoiding the not_same_branch error
405
# avoiding the not_same_branch error
406
t::lib::Mocks::mock_preference('IndependentBranches', 0);
406
t::lib::Mocks::mock_preference('IndependentBranches', 0);
407
my $item = Koha::Items->find($itemnumber);
407
$item = Koha::Items->find($item->itemnumber);
408
is(
408
is(
409
    $item->safe_delete,
409
    $item->safe_delete,
410
    'book_reserved',
410
    'book_reserved',
411
- 

Return to bug 23463