From 3e82b5b19156b8b5af6ea3fb0407be1742c81ed1 Mon Sep 17 00:00:00 2001 From: Bernardo Gonzalez Kriegel Date: Fri, 20 Mar 2020 19:35:29 -0300 Subject: [PATCH] Bug 24883: Add POD entry and remove unused variable --- C4/Installer.pm | 23 ++++++++++++++++------- misc/load_yaml.pl | 2 +- 2 files changed, 17 insertions(+), 8 deletions(-) diff --git a/C4/Installer.pm b/C4/Installer.pm index 06231d93b0..5b61b89b11 100644 --- a/C4/Installer.pm +++ b/C4/Installer.pm @@ -447,15 +447,12 @@ sub set_version_syspref { C4::Context->clear_syspref_cache(); } -=head2 load_sql - - my $error = $installer->load_sql($filename); +=head2 process_yml_table -Runs the specified input file using a sql loader DBIx::RunSQL, or a yaml loader -Returns any strings sent to STDERR + my $query_info = $installer->process_yml_table($table); -# FIXME This should be improved: sometimes the caller and load_sql warn the same -error. +Analyzes a table loaded in YAML format. +Returns the values required to build an insert statement. =cut @@ -480,6 +477,18 @@ sub process_yml_table { return { query => $query, placeholders => $placeholders, values => \@values }; } +=head2 load_sql + + my $error = $installer->load_sql($filename); + +Runs the specified input file using a sql loader DBIx::RunSQL, or a yaml loader +Returns any strings sent to STDERR + +# FIXME This should be improved: sometimes the caller and load_sql warn the same +error. + +=cut + sub load_sql { my $self = shift; my $filename = shift; diff --git a/misc/load_yaml.pl b/misc/load_yaml.pl index b12d88d886..118c394e13 100755 --- a/misc/load_yaml.pl +++ b/misc/load_yaml.pl @@ -41,7 +41,7 @@ USAGE } # Getting parameters -my ( @files, $dump, $load, $help ); +my ( @files, $load, $help ); GetOptions( 'help|h' => \$help, -- 2.17.1