Bugzilla – Attachment 101415 Details for
Bug 23463
Move C4::Items CRUD subroutines to Koha::Item
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23463: (RM follow-up) Add try block around Illrequest item creation
Bug-23463-RM-follow-up-Add-try-block-around-Illreq.patch (text/plain), 1.17 KB, created by
Martin Renvoize
on 2020-03-23 10:36:38 UTC
(
hide
)
Description:
Bug 23463: (RM follow-up) Add try block around Illrequest item creation
Filename:
MIME Type:
Creator:
Martin Renvoize
Created:
2020-03-23 10:36:38 UTC
Size:
1.17 KB
patch
obsolete
>From 2edd08b4d820a9cbecb548c7e238b1322acbca9e Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Mon, 23 Mar 2020 10:31:39 +0000 >Subject: [PATCH] Bug 23463: (RM follow-up) Add try block around Illrequest > item creation > >The recently introduced Ill item creation for circulation feature was >not properly handling the move from AddItem to Koha::Item->new()->store. > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > Koha/Illrequest.pm | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > >diff --git a/Koha/Illrequest.pm b/Koha/Illrequest.pm >index cd5a593151..bc39152d58 100644 >--- a/Koha/Illrequest.pm >+++ b/Koha/Illrequest.pm >@@ -1172,8 +1172,10 @@ sub check_out { > itype => $params->{item_type}, > barcode => 'ILL-' . $self->illrequest_id > }; >- my $item = Koha::Item->new($item_hash); >- $itemnumber = $item->itemnumber; >+ try { >+ my $item = Koha::Item->new($item_hash)->store; >+ $itemnumber = $item->itemnumber; >+ }; > } else { > $itemnumber = $items[0]->itemnumber; > } >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23463
:
95899
|
95900
|
95901
|
95902
|
95903
|
95904
|
95905
|
95906
|
95907
|
95908
|
95909
|
95910
|
95911
|
95912
|
95913
|
95914
|
95915
|
95916
|
95917
|
95918
|
95919
|
95920
|
95921
|
95922
|
95923
|
95925
|
96145
|
97895
|
97896
|
97897
|
97898
|
97899
|
97900
|
97901
|
97902
|
97903
|
97904
|
97905
|
97906
|
97907
|
97908
|
97909
|
97910
|
97911
|
97912
|
97913
|
97914
|
97915
|
97916
|
97917
|
97918
|
97919
|
97920
|
97921
|
101151
|
101152
|
101153
|
101154
|
101156
|
101157
|
101158
|
101161
|
101163
|
101165
|
101167
|
101169
|
101170
|
101171
|
101172
|
101173
|
101174
|
101175
|
101176
|
101177
|
101178
|
101179
|
101180
|
101181
|
101182
|
101183
|
101184
|
101185
|
101186
|
101188
|
101189
|
101190
|
101191
|
101192
|
101193
|
101194
|
101195
|
101196
|
101197
|
101246
|
101247
|
101248
|
101249
|
101250
|
101251
|
101252
|
101253
|
101254
|
101255
|
101256
|
101257
|
101258
|
101259
|
101260
|
101261
|
101262
|
101263
|
101264
|
101265
|
101266
|
101267
|
101268
|
101269
|
101270
|
101271
|
101272
|
101273
|
101274
|
101275
|
101276
|
101277
|
101278
|
101279
|
101280
|
101281
|
101282
|
101283
|
101284
|
101413
|
101414
| 101415 |
101416
|
101432
|
101476
|
102071
|
103129
|
113581