Bugzilla – Attachment 101432 Details for
Bug 23463
Move C4::Items CRUD subroutines to Koha::Item
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23463: Fix selenium tests (highlight a bug in date management)
Bug-23463-Fix-selenium-tests-highlight-a-bug-in-da.patch (text/plain), 2.17 KB, created by
Jonathan Druart
on 2020-03-23 12:14:45 UTC
(
hide
)
Description:
Bug 23463: Fix selenium tests (highlight a bug in date management)
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2020-03-23 12:14:45 UTC
Size:
2.17 KB
patch
obsolete
>From d87351626d9bd9934da67e5963fc112aceb30f07 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Mon, 23 Mar 2020 13:09:07 +0100 >Subject: [PATCH] Bug 23463: Fix selenium tests (highlight a bug in date > management) > >There is something wrong, and a regression has been caught by those >tests: >If an invalid date is passed from the add item form, the app now >crashes. >Before: > * if the date was completely invalid, the field was blanked >silently > * DateTime::Format::MySQL was used to convert dates, and it's not > strict at all. For instance, what happened in the selenium tests for > dateaccessionned: %Y-%m-%d was prefilled by the framework plugin, then > the biblionumber was added, we ended with something like (eg for today) > 2020-03-234242 (with biblionumber=4242). DateTime::Format::MySQL > converts that to 2020-03-23 > >We must deal with invalid dates, but I do not think it is good to add it >back to Koha::Item->store, we will prefer to raise the error to the end >user, saying that something went wrong (and more specifically the >dates). > >The (ugly) trick was in C4::Items::_mod_item_dates >--- > t/db_dependent/selenium/basic_workflow.t | 11 +++++++++++ > 1 file changed, 11 insertions(+) > >diff --git a/t/db_dependent/selenium/basic_workflow.t b/t/db_dependent/selenium/basic_workflow.t >index 62dcf0e470..a988bb8683 100644 >--- a/t/db_dependent/selenium/basic_workflow.t >+++ b/t/db_dependent/selenium/basic_workflow.t >@@ -35,6 +35,7 @@ > use Modern::Perl; > > use Time::HiRes qw(gettimeofday); >+use POSIX qw(strftime); > use C4::Context; > use C4::Biblio qw( AddBiblio ); # We shouldn't use it > >@@ -197,6 +198,16 @@ SKIP: { > # It's a varchar(10) > $v = 't_value_x'; > } >+ elsif ( >+ $id =~ m|^tag_952_subfield_w| # replacementpricedate >+ ) { >+ $v = strftime("%Y-%m-%d", localtime); >+ } >+ elsif ( >+ $id =~ m|^tag_952_subfield_d| # dateaccessioned >+ ) { >+ $v = ""; # The input has been prefilled with %Y-%m-%d already >+ } > else { > $v = 't_value_bib' . $biblionumber; > } >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23463
:
95899
|
95900
|
95901
|
95902
|
95903
|
95904
|
95905
|
95906
|
95907
|
95908
|
95909
|
95910
|
95911
|
95912
|
95913
|
95914
|
95915
|
95916
|
95917
|
95918
|
95919
|
95920
|
95921
|
95922
|
95923
|
95925
|
96145
|
97895
|
97896
|
97897
|
97898
|
97899
|
97900
|
97901
|
97902
|
97903
|
97904
|
97905
|
97906
|
97907
|
97908
|
97909
|
97910
|
97911
|
97912
|
97913
|
97914
|
97915
|
97916
|
97917
|
97918
|
97919
|
97920
|
97921
|
101151
|
101152
|
101153
|
101154
|
101156
|
101157
|
101158
|
101161
|
101163
|
101165
|
101167
|
101169
|
101170
|
101171
|
101172
|
101173
|
101174
|
101175
|
101176
|
101177
|
101178
|
101179
|
101180
|
101181
|
101182
|
101183
|
101184
|
101185
|
101186
|
101188
|
101189
|
101190
|
101191
|
101192
|
101193
|
101194
|
101195
|
101196
|
101197
|
101246
|
101247
|
101248
|
101249
|
101250
|
101251
|
101252
|
101253
|
101254
|
101255
|
101256
|
101257
|
101258
|
101259
|
101260
|
101261
|
101262
|
101263
|
101264
|
101265
|
101266
|
101267
|
101268
|
101269
|
101270
|
101271
|
101272
|
101273
|
101274
|
101275
|
101276
|
101277
|
101278
|
101279
|
101280
|
101281
|
101282
|
101283
|
101284
|
101413
|
101414
|
101415
|
101416
| 101432 |
101476
|
102071
|
103129
|
113581