Bugzilla – Attachment 101528 Details for
Bug 21503
Update AuthorisedValues.pm to fall back to code if description doesn't exist
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21503: Changed logic for checking values
Bug-21503-Changed-logic-for-checking-values.patch (text/plain), 1.49 KB, created by
Jonathan Druart
on 2020-03-24 10:07:02 UTC
(
hide
)
Description:
Bug 21503: Changed logic for checking values
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2020-03-24 10:07:02 UTC
Size:
1.49 KB
patch
obsolete
>From cf16ba5b37eb7e9ba8e729d6cc47f93144e2907f Mon Sep 17 00:00:00 2001 >From: Christopher Brannon <cbrannon@cdalibrary.org> >Date: Wed, 17 Oct 2018 21:19:43 +0000 >Subject: [PATCH] Bug 21503: Changed logic for checking values > >Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> > >Bug 21503: Simplify If Else logic > >Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > Koha/Template/Plugin/AuthorisedValues.pm | 18 +++++++++++------- > 1 file changed, 11 insertions(+), 7 deletions(-) > >diff --git a/Koha/Template/Plugin/AuthorisedValues.pm b/Koha/Template/Plugin/AuthorisedValues.pm >index b15136e5b7..ae90288fb7 100644 >--- a/Koha/Template/Plugin/AuthorisedValues.pm >+++ b/Koha/Template/Plugin/AuthorisedValues.pm >@@ -81,13 +81,17 @@ sub GetDescriptionByKohaField { > authorised_value => $params->{authorised_value}, > } > ); >- return %$av >- ? $params->{opac} >- ? $av->{opac_description} >- : $av->{lib} >- : $params->{authorised_value} >- ? $params->{authorised_value} >- : '' >+ my $av_check = $params->{authorised_value}; >+ if ($params->{opac}) { >+ if ($av->{opac_description}) { >+ $av_check = $av->{opac_description} >+ } elsif ($av->{lib}) { >+ $av_check = $av->{lib} >+ } >+ } elsif ($av->{lib}) { >+ $av_check = $av->{lib} >+ } >+ return $av_check > } > > 1; >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21503
:
80151
|
80152
|
80233
|
80439
|
80521
|
80544
|
80545
|
80558
|
80561
|
80562
|
80563
|
80601
|
80758
|
80759
|
80762
|
101323
|
101324
|
101325
|
101326
|
101327
|
101328
|
101524
|
101525
|
101526
|
101527
|
101528
|
101529
|
101533
|
101534
|
101535