From cbb2109abb2b035f6ebe8e00cd8ccbcdd7c3f036 Mon Sep 17 00:00:00 2001
From: Katrin Fischer <katrin.fischer.83@web.de>
Date: Fri, 27 Mar 2020 23:48:56 +0100
Subject: [PATCH] Bug 25011: Add MARC21 508 - Production credits to staff
 detail page

Bug 13385 added 508 to the OPAC detail page, but missed the staff
side. This patch makes the display consistent again between staff
and OPAC.

Additional changes:
- Capitalization fix: Production Credits - Production credits
- Changes div to span avoiding display issues

To test:
- Catalog one or more records with none, one and multiple 508 $a
- Check and compare the staff and OPAC detail pages, both
  should display the production credits information now correctly
---
 .../en/xslt/MARC21slim2intranetDetail.xsl     | 13 +++++++++++
 .../en/xslt/MARC21slim2OPACDetail.xsl         | 22 +++++++++----------
 2 files changed, 24 insertions(+), 11 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl b/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl
index d44322d6ff..e9f9132a4a 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl
+++ b/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl
@@ -996,6 +996,19 @@
             </div>
         </xsl:if>
 
+        <!-- 508 -->
+        <xsl:if test="marc:datafield[@tag=508]">
+            <span class="results_summary prod_credits">
+                <span class="label">Production credits: </span>
+                <xsl:for-each select="marc:datafield[@tag=508]">
+                    <xsl:call-template name="subfieldSelectSpan">
+                        <xsl:with-param name="codes">a</xsl:with-param>
+                    </xsl:call-template>
+                    <xsl:if test="position()!=last()"><span class="separator"><xsl:text> | </xsl:text></span></xsl:if>
+                </xsl:for-each>
+            </span>
+        </xsl:if>
+
         <!-- 586 -->
         <xsl:if test="marc:datafield[@tag=586]">
             <span class="results_summary awardsnote">
diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl
index 0ade99700c..cd0bf1c109 100644
--- a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl
+++ b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl
@@ -1103,17 +1103,17 @@
         </xsl:if>
 
         <!-- 508 -->
-            <xsl:if test="marc:datafield[@tag=508]">
-                <div class="results_summary prod_credits">
-                    <span class="label">Production Credits: </span>
-                    <xsl:for-each select="marc:datafield[@tag=508]">
-                        <xsl:call-template name="subfieldSelectSpan">
-                            <xsl:with-param name="codes">a</xsl:with-param>
-                        </xsl:call-template>
-                        <xsl:if test="position()!=last()"><span class="separator"><xsl:text> | </xsl:text></span></xsl:if>
-                    </xsl:for-each>
-                </div>
-            </xsl:if>
+        <xsl:if test="marc:datafield[@tag=508]">
+            <span class="results_summary prod_credits">
+                <span class="label">Production credits: </span>
+                <xsl:for-each select="marc:datafield[@tag=508]">
+                    <xsl:call-template name="subfieldSelectSpan">
+                        <xsl:with-param name="codes">a</xsl:with-param>
+                    </xsl:call-template>
+                    <xsl:if test="position()!=last()"><span class="separator"><xsl:text> | </xsl:text></span></xsl:if>
+                </xsl:for-each>
+            </span>
+        </xsl:if>
 
         <!-- 586 -->
         <xsl:if test="marc:datafield[@tag=586]">
-- 
2.17.1