Bugzilla – Attachment 102142 Details for
Bug 25024
OPAC incorrectly marks branch as invalid pickup location when similarly named branch is blocked
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 25024: Make grep match full string
Bug-25024-Make-grep-match-full-string.patch (text/plain), 2.37 KB, created by
Andrew Fuerste-Henry
on 2020-03-31 14:38:13 UTC
(
hide
)
Description:
Bug 25024: Make grep match full string
Filename:
MIME Type:
Creator:
Andrew Fuerste-Henry
Created:
2020-03-31 14:38:13 UTC
Size:
2.37 KB
patch
obsolete
>From cdbd1e1484aa50c80bf30effb5bd3e896a4bf2ee Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Tue, 31 Mar 2020 13:55:21 +0000 >Subject: [PATCH] Bug 25024: Make grep match full string > >To test: >1 - Create or have a branch with code CPL >2 - Create two new branches 'ACPL' and 'CPLA' >3 - In branch transfer limits disallow some itype or collection from another branch (FPL) to ACPL and CPLA >4 - Set UseBranchTransferLimits to 'Enforce' >5 - Find a biblio with one item belonging to FPL >6 - On opac, attempt to place a hold >7 - Note that ACPL and CPLA don't show in dropdown, OK >8 - Note that CPL is disabled, NOT OK >9 - Apply patch >10 - Place hold >11 - CPL is now enabled > >Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> >--- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt >index d637f705d8..8fad82e3b3 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt >@@ -245,7 +245,7 @@ > [% SET at_least_one_library_not_available_for_pickup = 0 %] > <select name="branch" id="branch_[% bibitemloo.biblionumber | html %]"> > [% FOREACH library IN Branches.pickup_locations({ search_params => { biblio => bibitemloo.biblionumber, patron => logged_in_user }, selected => branch }) %] >- [% SET pickup_available_at = bibitemloo.not_available_at.grep(library.branchcode).size ? 0 : 1 %] >+ [% SET pickup_available_at = bibitemloo.not_available_at.grep("^" _ library.branchcode _ "\$").size ? 0 : 1 %] > [% IF library.selected AND pickup_available_at %] > <option value="[% library.branchcode | html %]" selected="selected" >[% library.branchname | html %]</option> > [% ELSIF pickup_available_at %] >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 25024
:
102139
|
102142
|
102146
|
102177
|
102178