View | Details | Raw Unified | Return to bug 22001
Collapse All | Expand All

(-)a/t/db_dependent/Illrequests.t (-1 / +1 lines)
Lines 893-899 subtest 'Checking out' => sub { Link Here
893
            item_type => $itemtype->itemtype,
893
            item_type => $itemtype->itemtype,
894
            branchcode => '---'
894
            branchcode => '---'
895
        });
895
        });
896
    } qr/^DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails/,
896
    } qr/DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails/,
897
    "Item creation fails on bad parameters";
897
    "Item creation fails on bad parameters";
898
898
899
    is_deeply($form_stage_bad_branchcode->{value}->{errors}, {
899
    is_deeply($form_stage_bad_branchcode->{value}->{errors}, {
(-)a/t/db_dependent/Reports/Guided.t (-4 / +4 lines)
Lines 257-263 subtest 'get_saved_reports' => sub { Link Here
257
    warning_like {local $dbh->{RaiseError} = 0; ($sth, $errors) = execute_query(
257
    warning_like {local $dbh->{RaiseError} = 0; ($sth, $errors) = execute_query(
258
            'SELECT surname FRM borrowers',  # error in the query is intentional
258
            'SELECT surname FRM borrowers',  # error in the query is intentional
259
            0, 10 ) }
259
            0, 10 ) }
260
            qr/^DBD::mysql::st execute failed: You have an error in your SQL syntax;/,
260
            qr/DBD::mysql::st execute failed: You have an error in your SQL syntax;/,
261
            "Wrong SQL syntax raises warning";
261
            "Wrong SQL syntax raises warning";
262
    ok(
262
    ok(
263
        defined($errors) && exists($errors->{queryerr}),
263
        defined($errors) && exists($errors->{queryerr}),
Lines 400-406 subtest 'Email report test' => sub { Link Here
400
400
401
    # for next test, we want to let execute_query capture any SQL errors
401
    # for next test, we want to let execute_query capture any SQL errors
402
    warning_like { local $dbh->{RaiseError} = 0; ($emails, $errors ) = C4::Reports::Guided::EmailReport({report_id => $report2, module => $letter1->{module} , code => $letter1->{code} }) }
402
    warning_like { local $dbh->{RaiseError} = 0; ($emails, $errors ) = C4::Reports::Guided::EmailReport({report_id => $report2, module => $letter1->{module} , code => $letter1->{code} }) }
403
        qr/^DBD::mysql::st execute failed/,
403
        qr/DBD::mysql::st execute failed/,
404
        'Error from bad report';
404
        'Error from bad report';
405
    is( $errors->[0]{FATAL}, 'REPORT_FAIL', "Bad report returns failure");
405
    is( $errors->[0]{FATAL}, 'REPORT_FAIL', "Bad report returns failure");
406
406
Lines 452-459 subtest 'nb_rows() tests' => sub { Link Here
452
    # for next test, we want to let execute_query capture any SQL errors
452
    # for next test, we want to let execute_query capture any SQL errors
453
    
453
    
454
    warning_like
454
    warning_like
455
        { local $dbh->{RaiseError} = 0; $nb_rows = nb_rows( $bad_query ) }
455
        { $nb_rows = nb_rows( $bad_query ) }
456
        qr/^DBD::mysql::st execute failed:/,
456
        qr/DBD::mysql::st execute failed:/,
457
        'Bad queries raise a warning';
457
        'Bad queries raise a warning';
458
458
459
    is( $nb_rows, 0, 'nb_rows returns 0 on bad queries' );
459
    is( $nb_rows, 0, 'nb_rows returns 0 on bad queries' );
(-)a/t/db_dependent/api/v1/acquisitions_orders.t (-1 / +1 lines)
Lines 222-228 subtest 'add() tests' => sub { Link Here
222
          ->status_is(409)
222
          ->status_is(409)
223
          ->json_has( '/error' => "Fails when trying to add an existing order_id")
223
          ->json_has( '/error' => "Fails when trying to add an existing order_id")
224
          ->json_like( '/conflict' => qr/(aqorders\.)?PRIMARY/ ); }
224
          ->json_like( '/conflict' => qr/(aqorders\.)?PRIMARY/ ); }
225
        qr/^DBD::mysql::st execute failed: Duplicate entry '(.*)' for key '(aqorders\.)?PRIMARY'/;
225
        qr/DBD::mysql::st execute failed: Duplicate entry '(.*)' for key '(aqorders\.)?PRIMARY'/;
226
226
227
    $schema->storage->txn_rollback;
227
    $schema->storage->txn_rollback;
228
};
228
};
(-)a/t/db_dependent/api/v1/libraries.t (-1 / +1 lines)
Lines 203-209 subtest 'add() tests' => sub { Link Here
203
          ->status_is(409)
203
          ->status_is(409)
204
          ->json_has( '/error' => "Fails when trying to add an existing library_id")
204
          ->json_has( '/error' => "Fails when trying to add an existing library_id")
205
          ->json_like( '/conflict' => qr/(branches\.)?PRIMARY/ ); }
205
          ->json_like( '/conflict' => qr/(branches\.)?PRIMARY/ ); }
206
        qr/^DBD::mysql::st execute failed: Duplicate entry '(.*)' for key '(branches\.)?PRIMARY'/;
206
        qr/DBD::mysql::st execute failed: Duplicate entry '(.*)' for key '(branches\.)?PRIMARY'/;
207
207
208
    $schema->storage->txn_rollback;
208
    $schema->storage->txn_rollback;
209
};
209
};
(-)a/t/db_dependent/api/v1/patrons.t (-4 / +4 lines)
Lines 160-166 subtest 'add() tests' => sub { Link Here
160
            $t->post_ok("//$userid:$password@/api/v1/patrons" => json => $newpatron)
160
            $t->post_ok("//$userid:$password@/api/v1/patrons" => json => $newpatron)
161
              ->status_is(409)
161
              ->status_is(409)
162
              ->json_is('/error' => "Duplicate ID"); }
162
              ->json_is('/error' => "Duplicate ID"); }
163
            qr/^DBD::mysql::st execute failed: Duplicate entry/;
163
            qr/DBD::mysql::st execute failed: Duplicate entry/;
164
164
165
        $newpatron->{library_id} = $patron->branchcode;
165
        $newpatron->{library_id} = $patron->branchcode;
166
166
Lines 208-214 subtest 'add() tests' => sub { Link Here
208
              ->status_is(409)
208
              ->status_is(409)
209
              ->json_has( '/error', 'Fails when trying to POST duplicate cardnumber' )
209
              ->json_has( '/error', 'Fails when trying to POST duplicate cardnumber' )
210
              ->json_like( '/conflict' => qr/(borrowers\.)?cardnumber/ ); }
210
              ->json_like( '/conflict' => qr/(borrowers\.)?cardnumber/ ); }
211
            qr/^DBD::mysql::st execute failed: Duplicate entry '(.*?)' for key '(borrowers\.)?cardnumber'/;
211
            qr/DBD::mysql::st execute failed: Duplicate entry '(.*?)' for key '(borrowers\.)?cardnumber'/;
212
212
213
        $schema->storage->txn_rollback;
213
        $schema->storage->txn_rollback;
214
    };
214
    };
Lines 287-293 subtest 'update() tests' => sub { Link Here
287
            $t->put_ok("//$userid:$password@/api/v1/patrons/" . $patron_2->borrowernumber => json => $newpatron)
287
            $t->put_ok("//$userid:$password@/api/v1/patrons/" . $patron_2->borrowernumber => json => $newpatron)
288
              ->status_is(400)
288
              ->status_is(400)
289
              ->json_is('/error' => "Given library_id does not exist"); }
289
              ->json_is('/error' => "Given library_id does not exist"); }
290
            qr/^DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails/;
290
            qr/DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails/;
291
291
292
        # Restore the valid library_id
292
        # Restore the valid library_id
293
        $newpatron->{library_id} = $patron_2->branchcode;
293
        $newpatron->{library_id} = $patron_2->branchcode;
Lines 312-318 subtest 'update() tests' => sub { Link Here
312
              ->status_is(409)
312
              ->status_is(409)
313
              ->json_has( '/error', "Fails when trying to update to an existing cardnumber or userid")
313
              ->json_has( '/error', "Fails when trying to update to an existing cardnumber or userid")
314
              ->json_like( '/conflict' => qr/(borrowers\.)?cardnumber/ ); }
314
              ->json_like( '/conflict' => qr/(borrowers\.)?cardnumber/ ); }
315
            qr/^DBD::mysql::st execute failed: Duplicate entry '(.*?)' for key '(borrowers\.)?cardnumber'/;
315
            qr/DBD::mysql::st execute failed: Duplicate entry '(.*?)' for key '(borrowers\.)?cardnumber'/;
316
316
317
        $newpatron->{ cardnumber } = $patron_1->id . $patron_2->id;
317
        $newpatron->{ cardnumber } = $patron_1->id . $patron_2->id;
318
        $newpatron->{ userid }     = "user" . $patron_1->id.$patron_2->id;
318
        $newpatron->{ userid }     = "user" . $patron_1->id.$patron_2->id;
(-)a/t/db_dependent/api/v1/return_claims.t (-2 / +1 lines)
Lines 93-99 subtest 'claim_returned() tests' => sub { Link Here
93
            }
93
            }
94
        )->status_is(409)
94
        )->status_is(409)
95
    }
95
    }
96
    qr/^DBD::mysql::st execute failed: Duplicate entry/;
96
    qr/DBD::mysql::st execute failed: Duplicate entry/;
97
97
98
    $issue->delete;
98
    $issue->delete;
99
99
100
- 

Return to bug 22001