Bugzilla – Attachment 10249 Details for
Bug 5910
Authorities : allow users to search on all auth types
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 5910: [SIGNED-OFF] only add "All authority types" for UNIMARC
Bug-5910-SIGNED-OFF-only-add-All-authority-types-f.patch (text/plain), 3.54 KB, created by
Jonathan Druart
on 2012-06-12 13:06:56 UTC
(
hide
)
Description:
Bug 5910: [SIGNED-OFF] only add "All authority types" for UNIMARC
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2012-06-12 13:06:56 UTC
Size:
3.54 KB
patch
obsolete
>From aa9f59dc15760afa8d3926ba2150ff2911286687 Mon Sep 17 00:00:00 2001 >From: Jared Camins-Esakov <jcamins@cpbibliography.com> >Date: Sun, 10 Jun 2012 10:16:16 -0400 >Subject: [PATCH] Bug 5910: [SIGNED-OFF] only add "All authority types" for > UNIMARC > >UNIMARC is the only marcflavour that does not already have an option >for searching all authority types, so check that the marcflavour is >UNIMARC before displaying the additional "All authority types" option. > >Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> >--- > authorities/authorities-home.pl | 2 ++ > authorities/detail.pl | 2 ++ > .../prog/en/includes/authorities-search.inc | 6 +++--- > 3 files changed, 7 insertions(+), 3 deletions(-) > >diff --git a/authorities/authorities-home.pl b/authorities/authorities-home.pl >index e4eae84..d687c78 100755 >--- a/authorities/authorities-home.pl >+++ b/authorities/authorities-home.pl >@@ -177,5 +177,7 @@ $template->param( > authtypesloop => \@authtypesloop, > ); > >+$template->{VARS}->{marcflavour} = C4::Context->preference("marcflavour"); >+ > # Print the page > output_html_with_http_headers $query, $cookie, $template->output; >diff --git a/authorities/detail.pl b/authorities/detail.pl >index d4f2c67..90061cf 100755 >--- a/authorities/detail.pl >+++ b/authorities/detail.pl >@@ -242,5 +242,7 @@ $template->param(authid => $authid, > authtypetext => $authtypes->{$authtypecode}{'authtypetext'}, > authtypesloop => \@authtypesloop, > ); >+ >+$template->{VARS}->{marcflavour} = C4::Context->preference("marcflavour"); > output_html_with_http_headers $query, $cookie, $template->output; > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/authorities-search.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/authorities-search.inc >index 895b6cd..ca6f4af 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/authorities-search.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/authorities-search.inc >@@ -8,7 +8,7 @@ > <input type="hidden" name="op" value="do_search" /> > <input type="hidden" name="type" value="intranet" /> > <select name="authtypecode"> >- <option value="">All Authority Types</option> >+ [% IF (marcflavour == 'UNIMARC' ) %]<option value="">All authority types</option>[% END %] > [% FOREACH authtypesloo IN authtypesloop %] > [% IF ( authtypesloo.selected ) %] > <option value="[% authtypesloo.value %]" selected="selected">[% authtypesloo.authtypetext %]</option> >@@ -38,7 +38,7 @@ > <input type="hidden" name="op" value="do_search" /> > <input type="hidden" name="type" value="intranet" /> > <select name="authtypecode"> >- <option value="">All Authority Types</option> >+ [% IF (marcflavour == 'UNIMARC' ) %]<option value="">All authority types</option>[% END %] > [% FOREACH authtypesloo IN authtypesloop %] > [% IF ( authtypesloo.selected ) %] > <option value="[% authtypesloo.value %]" selected="selected">[% authtypesloo.authtypetext %]</option> >@@ -70,7 +70,7 @@ > <input type="hidden" name="op" value="do_search" /> > <input type="hidden" name="type" value="intranet" /> > <select name="authtypecode"> >- <option value="">All Authority Types</option> >+ [% IF (marcflavour == 'UNIMARC' ) %]<option value="">All authority types</option>[% END %] > [% FOREACH authtypesloo IN authtypesloop %] > [% IF ( authtypesloo.selected ) %] > <option value="[% authtypesloo.value %]" selected="selected">[% authtypesloo.authtypetext %]</option> >-- >1.7.7.3
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 5910
:
3373
|
4909
|
10116
|
10117
| 10249