Bugzilla – Attachment 102508 Details for
Bug 25038
OPAC reading history checkouts and on-site tabs not working
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 25038: Fix tabs on the OPAC reading history view
Bug-25038-Fix-tabs-on-the-OPAC-reading-history-vie.patch (text/plain), 2.56 KB, created by
Jonathan Druart
on 2020-04-07 11:26:36 UTC
(
hide
)
Description:
Bug 25038: Fix tabs on the OPAC reading history view
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2020-04-07 11:26:36 UTC
Size:
2.56 KB
patch
obsolete
>From 0b7448566b33902703ffc97f99160a06629f2927 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 7 Apr 2020 13:25:09 +0200 >Subject: [PATCH] Bug 25038: Fix tabs on the OPAC reading history view > >OPAC reading history table has three tabs for different checkout types: All, Checkouts, On-site checkouts. > >However, all of your checkouts are visible every tab regardless of checkout type. > >Test plan: >1. Enable OnSiteCheckouts system preference >2. Perform two checkouts: one normal checkout, one on-site checkout >3. Go to OPAC /cgi-bin/koha/opac-readingrecord.pl >4. Observe your checkouts all are visible in first tab >5. Select second tab and notice that the table is now filtered >6. Same with third tab >--- > .../bootstrap/en/modules/opac-readingrecord.tt | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt >index 91da402058..1f3dadcff5 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt >@@ -66,9 +66,9 @@ > [% IF Koha.Preference( 'OnSiteCheckouts' ) == 1 %] > <div id="tabs" class="toptabs"> > <ul> >- <li><a href="#tabs-container" id="tab_all">All</a></li> >- <li><a href="#tabs-container" id="tab_checkout">Checkouts</a></li> >- <li><a href="#tabs-container" id="tab_onsite_checkout">On-site checkouts</a></li> >+ <li id="tab_all"><a href="#tabs-container">All</a></li> >+ <li id="tab_checkout"><a href="#tabs-container">Checkouts</a></li> >+ <li id="tab_onsite_checkout"><a href="#tabs-container">On-site checkouts</a></li> > </ul> > [% END %] > <div id="tabs-container" style="overflow:hidden"> >@@ -223,8 +223,8 @@ > ] > })); > var tabs = $("#tabs").tabs({ >- select: function(e, ui) { >- var id = $(ui.tab).attr("id"); >+ activate: function(e, ui) { >+ var id = $(ui.newTab).attr("id"); > if ( id == "tab_checkout" ) { > table.fnFilter("standard_checkout", 0); > } else if ( id == "tab_onsite_checkout" ) { >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 25038
:
102508
|
102509
|
102693
|
102770