Bugzilla – Attachment 102535 Details for
Bug 7046
subscription renewal period should be a pull down
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 7046: Simplify dropdown list construction
Bug-7046-Simplify-dropdown-list-construction.patch (text/plain), 2.77 KB, created by
Jonathan Druart
on 2020-04-08 08:54:25 UTC
(
hide
)
Description:
Bug 7046: Simplify dropdown list construction
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2020-04-08 08:54:25 UTC
Size:
2.77 KB
patch
obsolete
>From 3a66a91887c51ecec322ccbc46f63d3b24470623 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Wed, 8 Apr 2020 10:42:41 +0200 >Subject: [PATCH] Bug 7046: Simplify dropdown list construction > >--- > .../en/modules/serials/subscription-renew.tt | 32 ++++++------------- > serials/subscription-renew.pl | 1 - > 2 files changed, 9 insertions(+), 24 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-renew.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-renew.tt >index 614e4d5e41..43cfa17846 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-renew.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-renew.tt >@@ -38,30 +38,16 @@ > <li> > <label>Subscription length:</label> > <select name="subtype" id="subtype"> >- [% FOREACH st IN subtypes %] >+ [% FOREACH st IN ['numberlength', 'weeklength', 'monthlength'] %] >+ [% IF st == subtype %] >+ <option value="issues" selected="selected"> >+ [% ELSE %] >+ <option value="issues"> >+ [% END %] > [% SWITCH st %] >- [% CASE 'numberlength'%] >- [% IF st == subtype %] >- <option value="issues" selected="selected"> >- [% ELSE %] >- <option value="issues"> >- [% END %] >- issues >- [% CASE 'weeklength' %] >- [% IF st == subtype %] >- <option value="weeks" selected="selected"> >- [% ELSE %] >- <option value="weeks"> >- [% END %] >- weeks >- [% CASE 'monthlength' %] >- [% IF st == subtype %] >- <option value="months" selected="selected"> >- [% ELSE %] >- <option value="months"> >- [% END %] >- months >- [% CASE %][% st | html %] >+ [% CASE 'numberlength'%]issues >+ [% CASE 'weeklength' %]weeks >+ [% CASE 'monthlength' %]months > [% END %] > </option> > [% END %] >diff --git a/serials/subscription-renew.pl b/serials/subscription-renew.pl >index 954b007fac..1889f9a5b6 100755 >--- a/serials/subscription-renew.pl >+++ b/serials/subscription-renew.pl >@@ -135,7 +135,6 @@ my $libraries = Koha::Libraries->search( {}, { order_by => ['branchcode'] }, ); > $template->param( > op => $op, > libraries => $libraries, >- subtypes => [ qw( numberlength weeklength monthlength ) ], > ); > > output_html_with_http_headers $query, $cookie, $template->output; >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 7046
:
5938
|
5939
|
69355
|
69356
|
69408
|
81641
|
81642
|
102275
|
102276
|
102278
|
102425
|
102427
|
102428
|
102429
|
102430
|
102535
|
102536
|
102537
|
102538
|
102564