Bugzilla – Attachment 102697 Details for
Bug 24966
Fix calls to maybe_add where method call does not return a value
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 24966: (QA follow-up) Fix return value of hold_patron_bcode
Bug-24966-QA-follow-up-Fix-return-value-of-holdpat.patch (text/plain), 1.15 KB, created by
Kyle M Hall (khall)
on 2020-04-10 10:44:22 UTC
(
hide
)
Description:
Bug 24966: (QA follow-up) Fix return value of hold_patron_bcode
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2020-04-10 10:44:22 UTC
Size:
1.15 KB
patch
obsolete
>From a3de540fbf6f9bb5e2bf92efb78dcc9e5294fcf7 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Fri, 10 Apr 2020 09:50:13 +0000 >Subject: [PATCH] Bug 24966: (QA follow-up) Fix return value of > hold_patron_bcode > >It is used in list context, but we need a scalar value. >Can be fixed by adding scalar's, or returning empty string as here. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > C4/SIP/ILS/Item.pm | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/C4/SIP/ILS/Item.pm b/C4/SIP/ILS/Item.pm >index 3421bda6e9..37c9c6986a 100644 >--- a/C4/SIP/ILS/Item.pm >+++ b/C4/SIP/ILS/Item.pm >@@ -196,12 +196,12 @@ sub hold_patron_name { > > sub hold_patron_bcode { > my $self = shift; >- my $borrowernumber = (@_ ? shift: $self->hold_patron_id()) or return; >+ my $borrowernumber = (@_ ? shift: $self->hold_patron_id()) or return q{}; > my $holder = Koha::Patrons->find( $borrowernumber ); > if ($holder and $holder->cardnumber ) { > return $holder->cardnumber; > } >- return; >+ return q(); > } > > sub destination_loc { >-- >2.24.1 (Apple Git-126)
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 24966
:
101559
|
101632
|
102584
|
102585
|
102689
| 102697 |
102698