From f58d2a2fd51865cd49ee7acc73018af67d89d77b Mon Sep 17 00:00:00 2001
From: Katrin Fischer <katrin.fischer.83@web.de>
Date: Tue, 14 Apr 2020 01:48:03 +0000
Subject: [PATCH] Bug 14713: Add hint that updatecharges permissions require
 ability to view patron details

A staff usre with only updatecharges permissions or sub permissions but without
the ability to view patron details (borrowers permissions and sub permissions)
will not be able to access the fines and charges functionalities.

This patch adds a textual hint about the dependency to the permissions screen.

To test:
- Verify behaviour: Add a staff user with
  - updatecharges permissions
  - no borrowers permissions
- Try to access a patron fines record in the GUI
- Try by direct URL: cgi-bin/koha/members/pay.pl?borrowernumber=17
- Add borrowers permissions - everything should be accessible now
- Apply patch
- View the permissions of a staff user
- Verify there is now a note stating this fact

Signed-off-by: David Nind <david@davidnind.com>
---
 koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc
index 1179537930..f1bc5277a2 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc
+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc
@@ -26,7 +26,7 @@
         <span class="permissioncode">([% name | html %])</span>
     [%- CASE 'updatecharges' -%]
         <span class="main_permission updatecharges_permission">Manage patrons fines and fees</span>
-        <span class="permissioncode">([% name | html %])</span>
+        <span class="permissioncode">([% name | html %])</span> <span>Requires permissions to view patron details.</span>
     [%- CASE 'acquisition' -%]
         <span class="main_permission acquisition_permission">Acquisition management</span>
         <span class="permissioncode">([% name | html %])</span>
-- 
2.11.0