From 1d61d3031adddd1ec7f83b7ea2ae086dccd9e26f Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Wed, 15 Apr 2020 23:14:15 +0000 Subject: [PATCH] Bug 25166: Add "aria-hidden = true" to Font Awesome icons in the OPAC Font Awesome's accessibility guidelines (https://fontawesome.com/v4.7.0/accessibility/) suggest that we include 'aria-hidden="true"' in the icon markup. This prevents screen readers from trying to read the icon. This patch adds the attribute. To test apply the patch and browse the OPAC looking for any problems with icons: On search results, bibliographic details page, the cart, lists, etc. Check the source and verify that Font Awesome icons have the "aria-hidden" attribute. Signed-off-by: Bernardo Gonzalez Kriegel Attribute present, all looks good. The 'aria-label' attribute is not translatable, but it's another problem. --- .../bootstrap/en/includes/holds-table.inc | 14 +++---- .../en/includes/masthead-langmenu.inc | 6 +-- .../bootstrap/en/includes/masthead-sco.inc | 2 +- .../bootstrap/en/includes/masthead.inc | 16 ++++---- .../en/includes/opac-detail-sidebar.inc | 24 +++++------ .../bootstrap/en/includes/page-numbers.inc | 8 ++-- .../bootstrap/en/includes/shelfbrowser.inc | 4 +- .../en/includes/title-actions-menu.inc | 24 +++++------ .../bootstrap/en/modules/clubs/clubs-tab.tt | 4 +- .../bootstrap/en/modules/opac-ISBDdetail.tt | 6 +-- .../bootstrap/en/modules/opac-MARCdetail.tt | 6 +-- .../bootstrap/en/modules/opac-account.tt | 6 +-- .../bootstrap/en/modules/opac-basket.tt | 22 +++++----- .../bootstrap/en/modules/opac-detail.tt | 40 +++++++++---------- .../bootstrap/en/modules/opac-illrequests.tt | 8 ++-- .../bootstrap/en/modules/opac-main.tt | 2 +- .../bootstrap/en/modules/opac-reserve.tt | 4 +- .../bootstrap/en/modules/opac-results.tt | 16 ++++---- .../en/modules/opac-search-history.tt | 8 ++-- .../bootstrap/en/modules/opac-shelves.tt | 40 +++++++++---------- .../bootstrap/en/modules/opac-showreviews.tt | 2 +- .../bootstrap/en/modules/opac-suggestions.tt | 6 +-- .../bootstrap/en/modules/opac-user.tt | 4 +- .../bootstrap/en/modules/sci/sci-main.tt | 4 +- .../bootstrap/en/modules/sco/sco-main.tt | 14 +++---- 25 files changed, 145 insertions(+), 145 deletions(-) diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/holds-table.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/holds-table.inc index aea867a213..202311d30d 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/holds-table.inc +++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/holds-table.inc @@ -102,7 +102,7 @@ Status: [% IF ( HOLD.is_waiting ) %] - + [% IF ( HOLD.is_at_destination ) %] [% IF ( HOLD.found ) %] Item waiting at [% HOLD.branch.branchname | html %] @@ -141,11 +141,11 @@ [% IF HOLD.suspend %]
- +
[% ELSE %] [% IF AutoResumeSuspendedHolds %] - Suspend + Suspend [% # hold suspend modal form %]