Bugzilla – Attachment 103419 Details for
Bug 24957
OpenLibrarySearch shouldnt display if nothing is returned
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 24957: OpenLibrarySearch shouldnt display if nothing is returned
Bug-24957-OpenLibrarySearch-shouldnt-display-if-no.patch (text/plain), 1.25 KB, created by
ByWater Sandboxes
on 2020-04-21 20:58:28 UTC
(
hide
)
Description:
Bug 24957: OpenLibrarySearch shouldnt display if nothing is returned
Filename:
MIME Type:
Creator:
ByWater Sandboxes
Created:
2020-04-21 20:58:28 UTC
Size:
1.25 KB
patch
obsolete
>From 70cd10058841f6eaff3a1dbeb17a86baa98ec5a6 Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Tue, 21 Apr 2020 20:11:17 +0000 >Subject: [PATCH] Bug 24957: OpenLibrarySearch shouldnt display if nothing is > returned > >TO TEST: >1. Turn on OpenLibrarySearch >2. Do an OPAC search that returns results that have results with Open Library results and some that do not. >3. Notice results that return nothing simpliy say "Open Library:" with nothing afterwards. >4. Some results return a png from OpenLibrary or "Not found" >5. Apply patch and look at records again. >6. The results that return nothing for OpenLibrary API should now to hidden. > >Signed-off-by: Heather Hernandez <heather_hernandez@nps.gov> >--- > koha-tmpl/opac-tmpl/bootstrap/js/openlibrary.js | 2 ++ > 1 file changed, 2 insertions(+) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/js/openlibrary.js b/koha-tmpl/opac-tmpl/bootstrap/js/openlibrary.js >index 1c2a9f26cf..c33778de3c 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/js/openlibrary.js >+++ b/koha-tmpl/opac-tmpl/bootstrap/js/openlibrary.js >@@ -178,6 +178,8 @@ function default_decorate_el_fn(el, bookdata) { > } > if (decoration) { > el.innerHTML += decoration; >+ } else { >+ el.style.visibility = 'hidden'; > } > } > >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 24957
:
103417
|
103419
|
103518
|
117959
|
117960
|
117961