Bugzilla – Attachment 103719 Details for
Bug 25110
Allow patrons to add star ratings to titles on their summary/checkout page
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 25110: (QA follow-up) Add aria-hidden="true" to FA icons
Bug-25110-QA-follow-up-Add-aria-hiddentrue-to-FA-i.patch (text/plain), 1.86 KB, created by
Katrin Fischer
on 2020-04-25 23:25:03 UTC
(
hide
)
Description:
Bug 25110: (QA follow-up) Add aria-hidden="true" to FA icons
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2020-04-25 23:25:03 UTC
Size:
1.86 KB
patch
obsolete
>From 8ecac8959bea161cec3935a39dae90d26163b52d Mon Sep 17 00:00:00 2001 >From: Katrin Fischer <katrin.fischer.83@web.de> >Date: Sat, 25 Apr 2020 23:06:05 +0000 >Subject: [PATCH] Bug 25110: (QA follow-up) Add aria-hidden="true" to FA icons > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > koha-tmpl/opac-tmpl/bootstrap/en/includes/user-star-ratings.inc | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/user-star-ratings.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/user-star-ratings.inc >index 63b4bb87df..c0ebd2c0c7 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/user-star-ratings.inc >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/user-star-ratings.inc >@@ -42,11 +42,11 @@ > [% IF item.my_rating %] > <div> > <span class="rating_value_text">Your rating: [% item.my_rating.rating_value | html %].</span> >- <span class="cancel_rating_text js-show"><a href="#" data-context="star_rating-[% item.itemnumber | html %]"><i class="fa fa-remove"></i> Cancel rating</a>.</span> >+ <span class="cancel_rating_text js-show"><a href="#" data-context="star_rating-[% item.itemnumber | html %]"><i class="fa fa-remove" aria-hidden="true"></i> Cancel rating</a>.</span> > </div> > [% ELSE %] > <span class="rating_value_text"></span> >- <span class="cancel_rating_text" style="display:none;"><a href="#" data-context="star_rating-[% item.itemnumber | html %]"><i class="fa fa-remove"></i> Cancel rating</a>.</span> >+ <span class="cancel_rating_text" style="display:none;"><a href="#" data-context="star_rating-[% item.itemnumber | html %]"><i class="fa fa-remove" aria-hidden="true"></i> Cancel rating</a>.</span> > [% END %] > > <div class="rating_text">Average rating: [% rating_avg | html %] ([% item.ratings.count | html %] votes)</div> >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 25110
:
102938
|
103017
|
103080
|
103081
|
103365
|
103405
|
103718
| 103719