From d16313ae48f464cb6b5abf745458e8b2e5000a23 Mon Sep 17 00:00:00 2001 From: Timothy Alexis Vass Date: Tue, 28 Apr 2020 16:35:48 +0200 Subject: [PATCH] === Indentations are now consistently 4 spaces and opening/closing tags are now aligned. === example:
[% FOREACH ... %]

...

[% END %]
is now:
[% FOREACH ... %]

...

[% END %]
=== Whitespaces are now consistent === 1. Occuring > < and ] [ changed to >< and ][ example:
  • [% IF ( LibraryNameTitle ) %][% LibraryNameTitle | html %][% ELSE %]Koha online[% END %] catalog › Details for: [% INCLUDE 'biblio-title-head.inc' %] -[% INCLUDE 'doc-head-close.inc' %] + + [% IF ( LibraryNameTitle ) %][% LibraryNameTitle | html %][% ELSE %]Koha online[% END %] catalog › Details for: [% INCLUDE 'biblio-title-head.inc' %] + + [% INCLUDE 'doc-head-close.inc' %] [% Asset.css("lib/emoji-picker/css/emoji.css") | $raw %] [% IF ( Koha.Preference('OPACShowMusicalInscripts') ) %] [% Asset.css("lib/verovio/midiplayer.css") | $raw %] @@ -43,7 +45,7 @@
    @@ -51,7 +53,6 @@
    -
    [% IF ( OPACLocalCoverImages ) %]
    @@ -81,14 +82,18 @@ [% IF ( GoogleJackets ) %]
    [% END %] + [% IF ( Koha.Preference('OpacCoce') && Koha.Preference('CoceProviders') ) %] - [% coce_id = normalized_ean || normalized_isbn | html %] -
    + [% coce_id = normalized_ean || normalized_isbn | html %] +
    [% END %] + [% IF OpenLibraryCovers %]
    [% END %] + [% bt_id = ( normalized_upc || normalized_isbn ) %] + [% IF ( BakerTaylorEnabled && bt_id ) %] [% IF BakerTaylorBookstoreURL %] [% IF ( OPACURLOpenInNewWindow ) %] @@ -100,6 +105,7 @@ See Baker & Taylor [% END %] [% END %] + [% IF Koha.Preference('OPACCustomCoverImages') AND Koha.Preference('CustomCoverImagesURL') %] [% IF ( OPACURLOpenInNewWindow ) %] Cover image @@ -127,14 +133,17 @@

    [% INCLUDE 'biblio-title.inc' %]

    [% IF ( author ) %]
    by [% author | html %]
    [% END %] - [% UNLESS ( item_level_itypes ) %] - [ - [% IF ( description ) %] - [% description | html %] - [% ELSE %] - [% itemtype | html %] + + [% UNLESS ( item_level_itypes ) %] + [ + [% IF ( description ) %] + [% description | html %] + [% ELSE %] + [% itemtype | html %] + [% END %] + ] [% END %] - ] [% END %] + [% IF ( unititle ) %], [% unititle | html %][% END %] @@ -145,20 +154,23 @@ [% FOREACH MARCAUTHOR_SUBFIELDS_LOO IN MARCAUTHOR.MARCAUTHOR_SUBFIELDS_LOOP %] [% MARCAUTHOR_SUBFIELDS_LOO.separator | html %] [% IF ( MARCAUTHOR.authoritylink ) %] - + [% ELSE %] - + [% END %] [% MARCAUTHOR_SUBFIELDS_LOO.value | html %] [% END %] - [% IF (MARCAUTHOR.authoritylink) %] + + [% IF ( MARCAUTHOR.authoritylink ) %] [% END %] + [% IF IDREF and MARCAUTHOR.unimarc3 %] - IdRef + IdRef [% END %] + [% UNLESS ( loop.last ) %]|[% END %] - [% END # /FOREACH MARCAUTHORS %] + [% END # / FOREACH MARCAUTHORS %]
    [% END # IF MARCAUTHORS %] @@ -169,6 +181,7 @@ [% IF ( MARCSERIES_SUBFIELDS_LOO.value ) %] [% MARCSERIES_SUBFIELDS_LOO.value | html %] [% END %] + [% IF ( MARCSERIES_SUBFIELDS_LOO.volumenum ) %] . [% MARCSERIES_SUBFIELDS_LOO.volumenum | html %] [% END %] @@ -176,21 +189,24 @@ [% UNLESS ( loop.last ) %]|[% END %] [% END # / FOREACH MARCSERIES %] - [% END # /MARCSERIES %] + [% END # / MARCSERIES %] [% IF ( editionstatement ) %] Edition statement:[% editionstatement | html %][% IF ( editionresponsibility ) %]/[% editionresponsibility | html %][% END %] [% END %] + [% IF ( publishercode ) %] Published by : [% publishercode | html %] - [% IF ( place ) %]([% place | html %])[% END %] [% IF ( publicationyear ) %], [% publicationyear | html %][% END %] + + [% IF ( place ) %]([% place | html %])[% END %] + [% IF ( publicationyear ) %], [% publicationyear | html %][% END %] [% END %] [% IF ( pages ) %] - Physical details: [% pages | html %] [% illus | html %] [% size | html %] + Physical details:[% pages | html %][% illus | html %][% size | html %] [% END %] [% IF ( MARCISBNS ) %] @@ -208,8 +224,9 @@ [% IF ( collectiontitle ) %] Collection: [% collectiontitle | html %] - [% IF ( collectionissn ) %] [% ', ISSN ' _ collectionissn | html %][% END %] - [% IF ( collectionvolume ) %] [% ' ; ' _ collectionvolume | html %] [% END %] + [% IF ( collectionissn ) %][% ', ISSN ' _ collectionissn | html %][% END %] + + [% IF ( collectionvolume ) %][% ' ; ' _ collectionvolume | html %][% END %] [% END %] @@ -225,21 +242,22 @@ [% IF ( MARCSUBJCTS ) %]
    Subject(s): - [% FOREACH MARCSUBJCT IN MARCSUBJCTS %] [% subjectsloop = loop %] [% FOREACH SUBFIELD IN MARCSUBJCT.MARCSUBJECT_SUBFIELDS_LOOP %] [% SUBFIELD.separator | html %] [% SUBFIELD.value | html %] [% END %] - [% IF (MARCSUBJCT.authoritylink) %] + + [% IF ( MARCSUBJCT.authoritylink ) %] [% END %] + [% UNLESS ( loop.last ) %] | [% END %] [% END # / FOREACH MARCSUBJCTS %]
    - [% ELSE # /IF MARCSUBJCTS %] - [% IF ( subjects ) %]Subject(s): [% FOREACH subject IN subjects %][% subject.subject | html %] | [% END %][% END %] + [% ELSE # / IF MARCSUBJCTS %] + [% IF ( subjects ) %]Subject(s):[% FOREACH subject IN subjects %][% subject.subject | html %] | [% END %][% END %] [% END %] [% IF ( copyrightdate ) %] @@ -263,31 +281,32 @@
    Online resources:
    [% END # / IF MARCURLS %] @@ -322,14 +341,15 @@ Tags from this library: [% ELSE %] - Tags from this library: No tags from this library for this title. + Tags from this library:No tags from this library for this title. [% END %] + [% IF ( TagsInputEnabled ) %] [% IF ( loggedinusername ) %]
    - [% END # /IF TagsShowEnabled %] + [% END # / IF TagsShowEnabled %] [% IF ( SyndeticsEnabled ) %] [% IF ( SyndeticsSeries && SyndeticsSERIES1Exists ) %] @@ -371,7 +391,7 @@ Series information: Click to open in new window - [% END # / IF SyndeticsSeries && SyndeticsSERIES1Exists%] + [% END # / IF SyndeticsSeries && SyndeticsSERIES1Exists %] [% IF ( SyndeticsAVPROFILEExists ) %] Audiovisual profile: @@ -392,7 +412,7 @@ Click to open in new window [% END # / IF SyndeticsAwards && SyndeticsAWARDS1Exists %] - [% END # / IF SyndeticsEnabled%] + [% END # / IF SyndeticsEnabled %] [% IF ( OpacStarRatings != 'disable' ) %] @@ -406,6 +426,7 @@ [% ELSE %]