From bf964b0cc0c287c39fbe644f452238b0bf2fa057 Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Mon, 27 Apr 2020 15:21:30 +0000 Subject: [PATCH] Bug 25294: Don't show deletion button if user can't delete suggestions This patch adds logic to the OPAC suggestions template so that when the OPACViewOthersSuggestions system preference is enabled and the logged-in user is viewing other users' suggestions, the "Delete selected" button is only displayed when there are suggestions the user can delete. To test you should have suggestions in your system from at least two users. - Set the OPACViewOthersSuggestions preference to "Show" - Log in to the OPAC as a user who hasn't submitted any suggestions - Go to the suggestions page (with "?suggested_by_anyone=1" appended to the URL if necessary, see Bug 22515). - In the table of suggetions, there should be no titles with a checkbox in the first column. - At the bottom of the table there should be no "Delete selected" button. - Log in to the OPAC as a user with suggestions. - Return to the suggestions page and view all suggestions. - There should be titles with corresponding checkboxes and the "Delete selected" button should appear at the bottom. Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer --- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt index b1cf132113..9d0ec39c08 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt @@ -256,6 +256,7 @@ [% IF ( deleted ) %]
The selected suggestions have been deleted.
[% END %] [% IF ( suggestions_loop ) %] + [% SET can_delete_suggestion = 0 %]
@@ -321,6 +322,7 @@ [% IF ( loggedinusername ) %] [% IF ( suggestions_loo.showcheckbox ) %] + [% SET can_delete_suggestion = 1 %] [% END %] @@ -386,7 +388,7 @@ - [% IF ( loggedinusername ) %] + [% IF ( loggedinusername && can_delete_suggestion ) %]
-- 2.11.0