From 51a8bee4be16b986349fa65cb7ec39c91262edd9 Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Fri, 1 May 2020 13:23:12 +0000 Subject: [PATCH] Bug 24522: Show alert when trying to add nothing to a list in staff This patch modifies the JavaScript which handles the process of adding items to a list in the staff client. Error-handling is added in the case when a set of biblionumbers hasn't been passed to the vShelf function. To test, apply the patch and perform a catalog search in the staff client. On the search results page, select any list from the "Add to list" menu at the top of the search results table without checking any checkboxes. You should get an alert, "No item was selected." Also test that adding to a list works correctly after selecting one or more titles. Signed-off-by: Lucas Gass --- koha-tmpl/intranet-tmpl/prog/js/basket.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/koha-tmpl/intranet-tmpl/prog/js/basket.js b/koha-tmpl/intranet-tmpl/prog/js/basket.js index 5eadc9a6cb..aa5320f844 100644 --- a/koha-tmpl/intranet-tmpl/prog/js/basket.js +++ b/koha-tmpl/intranet-tmpl/prog/js/basket.js @@ -452,6 +452,8 @@ function vShelfAdd(biblist) { bibs.push("biblionumber=" + bibnums[i]); } return bibs.join("&"); + } else { + showListsUpdate(MSG_NO_RECORD_SELECTED); } } } -- 2.11.0