Bugzilla – Attachment 104276 Details for
Bug 23185
Koha::Objects supports passing through 'update' which means we can side step 'set' + 'store'
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23185: (QA follow-up) Add POD for Koha::Objects->update
Bug-23185-QA-follow-up-Add-POD-for-KohaObjects-upd.patch (text/plain), 1.10 KB, created by
Tomás Cohen Arazi
on 2020-05-04 12:55:02 UTC
(
hide
)
Description:
Bug 23185: (QA follow-up) Add POD for Koha::Objects->update
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi
Created:
2020-05-04 12:55:02 UTC
Size:
1.10 KB
patch
obsolete
>From 0b595d55aceb6b441bff83972581abdd0e815261 Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Mon, 4 May 2020 09:54:30 -0300 >Subject: [PATCH] Bug 23185: (QA follow-up) Add POD for Koha::Objects->update > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > Koha/Objects.pm | 11 +++++++++++ > 1 file changed, 11 insertions(+) > >diff --git a/Koha/Objects.pm b/Koha/Objects.pm >index 94271928b1..f39061aee9 100644 >--- a/Koha/Objects.pm >+++ b/Koha/Objects.pm >@@ -196,6 +196,17 @@ sub delete { > > =head3 update > >+ $object->update( $fields, [ { no_triggers => 0/1 } ] ); >+ >+This method overloads the DBIC inherited one so if code-level triggers exist >+(through the use of an overloaded I<update> or I<store> method in the Koha::Object >+based class) those are called in a loop on the resultset. >+ >+If B<no_triggers> is passed and I<true>, then the DBIC update method is called >+directly. This feature is important for performance, in cases no code-level >+triggers are defined. The developer will explicitly ask for this and QA should >+catch wrong uses as well. >+ > =cut > > sub update { >-- >2.26.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23185
:
103867
|
103868
|
103946
|
103947
|
104087
|
104088
|
104089
|
104232
|
104233
|
104234
|
104271
|
104272
|
104273
| 104276 |
104537
|
104538
|
104541