Bugzilla – Attachment 104360 Details for
Bug 25376
Use LANG authorised values for language facet
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 25376: Use LANG authorised values for language facet
Bug-25376-Use-LANG-authorised-values-for-language-.patch (text/plain), 3.00 KB, created by
Julian Maurice
on 2020-05-05 12:11:55 UTC
(
hide
)
Description:
Bug 25376: Use LANG authorised values for language facet
Filename:
MIME Type:
Creator:
Julian Maurice
Created:
2020-05-05 12:11:55 UTC
Size:
3.00 KB
patch
obsolete
>From 3127f2163c4582e6636c8180ac8246fc1ee1c1b1 Mon Sep 17 00:00:00 2001 >From: Julian Maurice <julian.maurice@biblibre.com> >Date: Thu, 30 Apr 2020 11:02:35 +0200 >Subject: [PATCH] Bug 25376: Use LANG authorised values for language facet > >Instead of relying on language_descriptions table, on which users have >no control, use LANG authorised values >It will give more control to users which will be able to add new >languages or change descriptions (for instance to translate them in their >own language) > >Test plan: >1. Do a search that return values for the language facet >2. Check that if you change a description in LANG authorised values, it > changes the displayed facet >--- > koha-tmpl/intranet-tmpl/prog/en/includes/facets.inc | 2 +- > koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-facets.inc | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/facets.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/facets.inc >index 243045b24a..001856074c 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/facets.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/facets.inc >@@ -35,7 +35,7 @@ > [% END %] > [% FOREACH facet IN facets_loo.facets %] > [% IF facets_loo.type_label_CollectionCodes %][% SET facet.facet_label_value = AuthorisedValues.GetByCode('CCODE',facet.facet_label_value,0) || facet.facet_label_value %][% END %] >- [% IF facets_loo.type_label_Language %][% SET facet.facet_label_value = Languages.GetByISOCode(lang,facet.facet_label_value) || facet.facet_label_value %][% END %] >+ [% IF facets_loo.type_label_Language %][% SET facet.facet_label_value = AuthorisedValues.GetByCode('LANG', facet.facet_label_value, 0) || facet.facet_label_value %][% END %] > [% IF loop.count > 5 && !facet.active %] > <li class="collapsible-facet" style="display:none"> > [% ELSE %] >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-facets.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-facets.inc >index da5e98134e..ff3d4efdc0 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-facets.inc >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-facets.inc >@@ -44,7 +44,7 @@ > [% END %] > [% FOREACH facet IN facets_loo.facets %] > [% IF facets_loo.type_label_CollectionCodes %][% SET facet.facet_label_value = AuthorisedValues.GetByCode('CCODE',facet.facet_label_value,1) || facet.facet_label_value %][% END %] >- [% IF facets_loo.type_label_Language %][% SET facet.facet_label_value = Languages.GetByISOCode(lang,facet.facet_label_value) || facet.facet_label_value %][% END %] >+ [% IF facets_loo.type_label_Language %][% SET facet.facet_label_value = AuthorisedValues.GetByCode('LANG', facet.facet_label_value, 1) || facet.facet_label_value %][% END %] > [% IF loop.count > 5 && !facet.active %] > <li class="collapsible-facet" style="display:none"> > [% ELSE %] >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 25376
: 104360