Bugzilla – Attachment 10440 Details for
Bug 8282
Bug in modules list in about.pl
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED OFF] Bug 8282: Bug in modules list in about.pl
Bug-8282-Bug-in-modules-list-in-aboutpl.patch (text/plain), 2.69 KB, created by
Marc Véron
on 2012-06-22 20:03:39 UTC
(
hide
)
Description:
[SIGNED OFF] Bug 8282: Bug in modules list in about.pl
Filename:
MIME Type:
Creator:
Marc Véron
Created:
2012-06-22 20:03:39 UTC
Size:
2.69 KB
patch
obsolete
>From 6130827059154b83f8010520dd7b8cb2a4c5f6e2 Mon Sep 17 00:00:00 2001 >From: Matthias Meusburger <matthias.meusburger@biblibre.com> >Date: Thu, 21 Jun 2012 15:41:54 +0200 >Subject: [PATCH] Bug 8282: Bug in modules list in about.pl >Content-Type: text/plain; charset="utf-8" > > Last modules were not displayed if the number of modules did not match the number of rows of the table (when $number_of_modules % 4 != 0) > >Signed-off-by: Marc Veron <veron@veron.ch> > >Added some code to about.tt to have empty the last remaining cells, not sure if an other signoff is needed. >--- > about.pl | 7 +++++++ > koha-tmpl/intranet-tmpl/prog/en/modules/about.tt | 13 ++++++++++--- > 2 files changed, 17 insertions(+), 3 deletions(-) > >diff --git a/about.pl b/about.pl >index 7189a22..d196a7f 100755 >--- a/about.pl >+++ b/about.pl >@@ -108,6 +108,13 @@ foreach (@components) { > $row = []; > } > } >+# Processing the last line (if there are any modules left) >+if (scalar(@$row) > 0) { >+ # Extending $row to the table size >+ $$row[3] = ''; >+ # Pushing the last line >+ push (@$table, {row => $row}); >+} > ## ## $table > > $template->param( table => $table ); >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt >index 2fd6655..0896c58 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt >@@ -69,15 +69,22 @@ > <th scope="row" style="background-color:#FFCB2F;font-weight:normal" title="Module upgrade needed"> > [% END %] > [% ELSE %] >- [% IF ( ro.require ) %] >+ [% IF ( ro.name == '' ) %] >+ <th> >+ [% ELSIF ( ro.require ) %] > <th scope="row" style="background-color:#FF8A8A;font-weight:bold;" title="Required module missing"> > [% ELSE %] > <th scope="row" style="background-color:#FF8A8A;font-weight:normal" title="Optional module missing"> > [% END %] > [% END %] >- [% ro.name %] >+ [% ro.name %] > </th> >- [% IF ( ro.version ) %]<td>[% ro.version %][% ELSE %]<td style="font-weight:bold">Not Installed[% END %]</td> >+ [% IF ( ro.name == '' ) %] >+ <td> >+ [% ELSIF ( ro.version ) %] >+ <td>[% ro.version %] >+ [% ELSE %] >+ <td style="font-weight:bold">Not Installed [% END %]</td> > [% END %] > </tr> > [% END %] >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 8282
:
10408
| 10440