Bugzilla – Attachment 104434 Details for
Bug 25279
Make the cities list use the API
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 25279: URI-escape city_id in links
Bug-25279-URI-escape-cityid-in-links.patch (text/plain), 2.36 KB, created by
Jonathan Druart
on 2020-05-06 14:13:11 UTC
(
hide
)
Description:
Bug 25279: URI-escape city_id in links
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2020-05-06 14:13:11 UTC
Size:
2.36 KB
patch
obsolete
>From 559d783a4ae1170eaf0604e352a29158373666df Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Wed, 6 May 2020 10:34:09 -0300 >Subject: [PATCH] Bug 25279: URI-escape city_id in links > >This patch escapes city_id uses in URLs, and also removes redundant dom >entry as this is inherited from the global datatables configuration >anyway. > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/admin/cities.tt | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/cities.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/cities.tt >index f25a6e8fd0..c5287fd9b7 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/cities.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/cities.tt >@@ -181,7 +181,6 @@ > "ajax": { > "url": cities_table_url > }, >- 'dom': 'C<"top pager"ilpfB><"#filter_c">tr<"bottom pager"ip>', > "order": [[ 1, "asc" ]], > "columnDefs": [ { > "targets": [0,1,2,3,4], >@@ -221,8 +220,8 @@ > { > "data": function( row, type, val, meta ) { > >- var result = '<a class="btn btn-default btn-xs" role="button" href="/cgi-bin/koha/admin/cities.pl?op=add_form&cityid='+ row.city_id +'"><i class="fa fa-pencil" aria-hidden="true"></i> '+_("Edit")+'</a>'+"\n"; >- result += '<a class="btn btn-default btn-xs" role="button" href="/cgi-bin/koha/admin/cities.pl?op=delete_confirm&cityid='+ row.city_id +'"><i class="fa fa-trash" aria-hidden="true"></i> '+_("Delete")+'</a>'; >+ var result = '<a class="btn btn-default btn-xs" role="button" href="/cgi-bin/koha/admin/cities.pl?op=add_form&cityid='+ encodeURIComponent(row.city_id) +'"><i class="fa fa-pencil" aria-hidden="true"></i> '+_("Edit")+'</a>'+"\n"; >+ result += '<a class="btn btn-default btn-xs" role="button" href="/cgi-bin/koha/admin/cities.pl?op=delete_confirm&cityid='+ encodeURIComponent(row.city_id) +'"><i class="fa fa-trash" aria-hidden="true"></i> '+_("Delete")+'</a>'; > return result; > > }, >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 25279
:
103693
|
103694
|
103802
|
103803
|
103804
|
104065
|
104072
|
104359
|
104387
|
104416
|
104417
|
104420
|
104421
|
104423
|
104427
|
104428
|
104429
|
104430
|
104431
|
104432
|
104433
| 104434 |
104435
|
104510