Bugzilla – Attachment 104693 Details for
Bug 25248
Delete All Items should redirect to detail.pl, not additem.pl
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 25248: (bug 23463 follow-up) Adjust second occurrence
Bug-25248-bug-23463-follow-up-Adjust-second-occurr.patch (text/plain), 1.02 KB, created by
Jonathan Druart
on 2020-05-11 13:14:24 UTC
(
hide
)
Description:
Bug 25248: (bug 23463 follow-up) Adjust second occurrence
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2020-05-11 13:14:24 UTC
Size:
1.02 KB
patch
obsolete
>From 3243ab7c356b1d7a85fa339113fb1aae65645b3b Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Mon, 11 May 2020 15:13:18 +0200 >Subject: [PATCH] Bug 25248: (bug 23463 follow-up) Adjust second occurrence > >Same as the precedent patch for a single item deletion (vs delete all >items) >Item is returned if deletion successful, not 1 >--- > cataloguing/additem.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/cataloguing/additem.pl b/cataloguing/additem.pl >index 8025241b6f..b0ce8b58c5 100755 >--- a/cataloguing/additem.pl >+++ b/cataloguing/additem.pl >@@ -675,7 +675,7 @@ if ($op eq "additem") { > # check that there is no issue on this item before deletion. > my $item = Koha::Items->find($itemnumber); > $error = $item->safe_delete; >- if($error ne '1'){ >+ if(ref($error) eq 'Koha::Item'){ > print $input->redirect("additem.pl?biblionumber=$biblionumber&frameworkcode=$frameworkcode&searchid=$searchid"); > }else{ > push @errors,$error; >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 25248
:
103477
|
103481
| 104693