Bugzilla – Attachment 104701 Details for
Bug 24378
Change wording on AUTO_RENEWALS notice in updatedatabase
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 24378: Change wording of auto_renewals notice in updatedatabase
Bug-24378-Change-wording-of-autorenewals-notice-in.patch (text/plain), 3.76 KB, created by
Jonathan Druart
on 2020-05-11 13:45:06 UTC
(
hide
)
Description:
Bug 24378: Change wording of auto_renewals notice in updatedatabase
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2020-05-11 13:45:06 UTC
Size:
3.76 KB
patch
obsolete
>From 9f4fadf833d9e82242c7dd80e8450e0e28b4cf28 Mon Sep 17 00:00:00 2001 >From: Andrew Fuerste-Henry <andrew@bywatersolutions.com> >Date: Wed, 11 Mar 2020 00:15:58 +0000 >Subject: [PATCH] Bug 24378: Change wording of auto_renewals notice in > updatedatabase > >On the template of AUTO-RENEWALS the wording is grammatically incorrect: > >[% IF checkout.auto_renew_error == 'too_many' %] >You have reach the maximum of checkouts possible. > >This should say >[% IF checkout.auto_renew_error == 'too_many' %] >You have reached the maximum of checkouts possible. > >Test plan: >- Make sure you have the AUTO_RENEWALS notice with the problematic > spelling >- install patch >- update database >- confirm changes to notice name and wording > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >Kept Andrew's change on the original updatedatabase entry, >but removed the database update to be done a little differently >in a follow-up patch. > >Amended test plan. > >Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > installer/data/mysql/updatedatabase.pl | 40 +++++++++++++------------- > 1 file changed, 20 insertions(+), 20 deletions(-) > >diff --git a/installer/data/mysql/updatedatabase.pl b/installer/data/mysql/updatedatabase.pl >index d751465be5..d31355c910 100755 >--- a/installer/data/mysql/updatedatabase.pl >+++ b/installer/data/mysql/updatedatabase.pl >@@ -14438,26 +14438,26 @@ if( CheckVersion( $DBversion ) ) { > } > > $dbh->do(q{ >- INSERT INTO letter (module, code, name, title, content, message_transport_type) VALUES ('circulation', 'AUTO_RENEWALS', 'notification on auto renewing', 'Auto renewals', >-"Dear [% borrower.firstname %] [% borrower.surname %], >-[% IF checkout.auto_renew_error %] >-The following item [% biblio.title %] has not been correctly renewed >-[% IF checkout.auto_renew_error == 'too_many' %] >-You have reach the maximum of checkouts possible. >-[% ELSIF checkout.auto_renew_error == 'on_reserve' %] >-This item is on hold for another patron. >-[% ELSIF checkout.auto_renew_error == 'restriction' %] >-You are currently restricted. >-[% ELSIF checkout.auto_renew_error == 'overdue' %] >-You have overdues. >-[% ELSIF checkout.auto_renew_error == 'auto_too_late' %] >-It\'s too late to renew this checkout. >-[% ELSIF checkout.auto_renew_error == 'auto_too_much_oweing' %] >-You have too much unpaid fines. >-[% END %] >-[% ELSE %] >-The following item [% biblio.title %] has correctly been renewed and is now due [% checkout.date_due %] >-[% END %]", 'email'); >+ INSERT INTO letter (module, code, name, title, content, message_transport_type) VALUES ('circulation', 'AUTO_RENEWALS', 'Notification of automatic renewal', 'Automatic renewal notice', >+ "Dear [% borrower.firstname %] [% borrower.surname %], >+ [% IF checkout.auto_renew_error %] >+ The following item, [% biblio.title %], has not been renewed because: >+ [% IF checkout.auto_renew_error == 'too_many' %] >+ You have reached the maximum number of checkouts possible. >+ [% ELSIF checkout.auto_renew_error == 'on_reserve' %] >+ This item is on hold for another patron. >+ [% ELSIF checkout.auto_renew_error == 'restriction' %] >+ You are currently restricted. >+ [% ELSIF checkout.auto_renew_error == 'overdue' %] >+ You have overdue items. >+ [% ELSIF checkout.auto_renew_error == 'auto_too_late' %] >+ It\'s too late to renew this item. >+ [% ELSIF checkout.auto_renew_error == 'auto_too_much_oweing' %] >+ Your total unpaid fines are too high. >+ [% END %] >+ [% ELSE %] >+ The following item, [% biblio.title %], has correctly been renewed and is now due on [% checkout.date_due %] >+ [% END %]", 'email'); > }); > > SetVersion( $DBversion ); >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 24378
:
100309
|
100416
|
100417
|
100479
|
100480
|
100485
|
102827
|
102828
|
102871
|
102872
|
104683
| 104701 |
104702
|
104703
|
104704