From 7370ecb441fc55e99a7564824705618eb52cd9ab Mon Sep 17 00:00:00 2001 From: Martin Renvoize Date: Mon, 11 May 2020 21:13:47 +0100 Subject: [PATCH] Bug 25417: (QA follow-up) Clarify _FixOverduesOnReturn test Signed-off-by: Martin Renvoize --- t/db_dependent/Circulation.t | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/t/db_dependent/Circulation.t b/t/db_dependent/Circulation.t index d769a67d1f..e765b77840 100755 --- a/t/db_dependent/Circulation.t +++ b/t/db_dependent/Circulation.t @@ -2827,7 +2827,7 @@ subtest '_FixAccountForLostAndFound' => sub { }; subtest '_FixOverduesOnReturn' => sub { - plan tests => 12; + plan tests => 14; my $manager = $builder->build_object({ class => "Koha::Patrons" }); t::lib::Mocks::mock_userenv({ patron => $manager, branchcode => $manager->branchcode }); @@ -2891,8 +2891,8 @@ subtest '_FixOverduesOnReturn' => sub { is( ref $credit, "Koha::Account::Line", "Found matching credit for fine forgiveness" ); is( $credit->amount + 0, -99, "Credit amount is set correctly" ); is( $credit->amountoutstanding + 0, 0, "Credit amountoutstanding is correctly set to 0" ); - $offset->delete; - + + # Bug 25417 - Only forgive fines where there is an amount oustanding to forgive $accountline->set( { debit_type_code => 'OVERDUE', @@ -2900,12 +2900,15 @@ subtest '_FixOverduesOnReturn' => sub { amountoutstanding => 0.00, } )->store(); + $offset->delete; C4::Circulation::_FixOverduesOnReturn( $patron->{borrowernumber}, $item->itemnumber, 1, 'RETURNED' ); $accountline->_result()->discard_changes(); $offset = Koha::Account::Offsets->search({ debit_id => $accountline->id, type => 'Forgiven' })->next(); is( $offset, undef, "No offset created when trying to forgive fine with no outstanding balance" ); + isnt( $accountline->status, 'UNRETURNED', 'Open fine ( account type OVERDUE ) has been closed out ( status not UNRETURNED )'); + is( $accountline->status, 'RETURNED', 'Passed status has been used to set as RETURNED )'); }; subtest '_FixAccountForLostAndFound returns undef if patron is deleted' => sub { -- 2.20.1