Bugzilla – Attachment 104826 Details for
Bug 24161
Add ability to track the claim dates of later orders
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 24161: Fix failing test (when running slow)
Bug-24161-Fix-failing-test-when-running-slow.patch (text/plain), 1.31 KB, created by
Jonathan Druart
on 2020-05-13 07:59:35 UTC
(
hide
)
Description:
Bug 24161: Fix failing test (when running slow)
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2020-05-13 07:59:35 UTC
Size:
1.31 KB
patch
obsolete
>From b6c3c19a6de4b1a93e6e410acea76ace9b73a666 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Wed, 13 May 2020 09:57:40 +0200 >Subject: [PATCH] Bug 24161: Fix failing test (when running slow) > >We "mocked" the claim date to make sure we were not going to hit this >problem, but it's not done on the correct claim, it should be done on >the last one (so second). > >from Koha::Acq::Order->claimed_date > >294 my $last_claim = $self->claims->last; >295 return unless $last_claim; >296 return $last_claim->claimed_on; >--- > t/db_dependent/Koha/Acquisition/Order.t | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/t/db_dependent/Koha/Acquisition/Order.t b/t/db_dependent/Koha/Acquisition/Order.t >index 8f1fd88311..7d1add94a4 100644 >--- a/t/db_dependent/Koha/Acquisition/Order.t >+++ b/t/db_dependent/Koha/Acquisition/Order.t >@@ -373,7 +373,7 @@ subtest 'claim*' => sub { > my $claim_1 = $order->claim; > my $claim_2 = $order->claim; > >- $claim_1->claimed_on($now->clone->subtract(days => 1))->store; >+ $claim_2->claimed_on($now->clone->subtract(days => 1))->store; > > is( $order->claims->count, 2, '->claims should return the correct number of claims'); > is( $order->claims_count, 2, '->claims_count should return the correct number of claims'); >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 24161
:
97114
|
97115
|
97116
|
97117
|
97118
|
97119
|
97470
|
97471
|
97472
|
98280
|
98522
|
98523
|
98524
|
98525
|
98526
|
98527
|
102111
|
102112
|
102113
|
102114
|
102115
|
102116
|
102220
|
102222
|
103567
|
103568
|
103569
|
103570
|
103571
|
103588
|
103589
|
103590
|
103591
|
103592
|
103593
|
103594
|
103595
|
104190
|
104191
|
104207
|
104208
|
104209
|
104210
|
104211
|
104212
|
104213
|
104214
|
104215
|
104216
|
104258
|
104259
|
104265
| 104826 |
104848