From a207bb549a878d8ee8b9332e90b787ce8d6dc033 Mon Sep 17 00:00:00 2001 From: Slava Shishkin Date: Tue, 19 May 2020 17:21:46 +0300 Subject: [PATCH] Bug 25533: Fix for 'Argument "" isn't numeric' warning Perl warning on the intranet "Holds" page (/cgi-bin/koha/reserve/request.pl) Argument "" isn't numeric in numeric gt (>) at .../C4/Reserves.pm line 2233. Fixed by assigning 0 for $holds_per_record when it has value that can be considered as false. To test: 1) Ensure that values of "Holds per record" is set to Unlimited on /cgi-bin/koha/admin/smart-rules.pl 2) Go to the intranet page (/cgi-bin/koha/reserve/request.pl). 3) Open item record, like /cgi-bin/koha/reserve/request.pl?biblionumber=1&borrowernumber=1 4) Observe the warning in the log file. 5) Apply patch. 6) Repeat steps 2 and 3. 7) Check that previous warning was suppressed. Mentored-by: Peter Vashchuk --- C4/Reserves.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/C4/Reserves.pm b/C4/Reserves.pm index 9f8d31637a..c7b2442a6e 100644 --- a/C4/Reserves.pm +++ b/C4/Reserves.pm @@ -2229,7 +2229,7 @@ sub GetMaxPatronHoldsForRecord { $branchcode = $item->homebranch if ( $controlbranch eq "ItemHomeLibrary" ); my $rule = GetHoldRule( $categorycode, $itemtype, $branchcode ); - my $holds_per_record = $rule ? $rule->{holds_per_record} : 0; + my $holds_per_record = $rule ? $rule->{holds_per_record} || 0 : 0; $max = $holds_per_record if $holds_per_record > $max; } -- 2.17.1