From afc2d2febb6ed83a650fb53e23c33be39e41e8c0 Mon Sep 17 00:00:00 2001 From: Slava Shishkin Date: Thu, 14 May 2020 17:53:47 +0300 Subject: [PATCH] Bug 25506: Fix for "Use of uninitialized value" in about.pl Perl warning on the "About Koha" page: Use of uninitialized value in string eq at /home/vagrant/kohaclone/about.pl line 220. Fixed by adding additional precheck for C4::Context->config('zebra_auth_index_mode') being Perl's "true". To test: 1) Ensure you don't have "... " in your koha-conf.xml so you will have "C4::Context->config" returning "undef" 2) Go to the "About Koha" page. 3) Observe the warning in the log file. 4) Apply patch. 5) Repeat step 2. 6) Check that previous warning was suppressed. Signed-off-by: Andreas Roussos Signed-off-by: Katrin Fischer --- about.pl | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/about.pl b/about.pl index fc8dcec21c..62a94d87f4 100755 --- a/about.pl +++ b/about.pl @@ -217,7 +217,10 @@ if ( C4::Context->config('zebra_auth_index_mode') push @xml_config_warnings, { error => 'zebra_auth_index_mode_is_grs1' }; } -if ( (C4::Context->config('zebra_auth_index_mode') eq 'dom') && ($context->{'server'}->{'authorityserver'}->{'config'} !~ /zebra-authorities-dom.cfg/) ) { +if( ( C4::Context->config('zebra_auth_index_mode') + and C4::Context->config('zebra_auth_index_mode') eq 'dom' ) + && ( $context->{'server'}->{'authorityserver'}->{'config'} !~ /zebra-authorities-dom.cfg/ ) ) +{ push @xml_config_warnings, { error => 'zebra_auth_index_mode_mismatch_warn' }; -- 2.11.0