From 443c374a8fc091ee9b26dc0dce544d0cdccbcf2f Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Fri, 22 May 2020 11:20:00 +0200 Subject: [PATCH] Bug 24612: Fix existing ReserveSlip tests --- t/db_dependent/Reserves/ReserveSlip.t | 38 +++------------------------ 1 file changed, 3 insertions(+), 35 deletions(-) diff --git a/t/db_dependent/Reserves/ReserveSlip.t b/t/db_dependent/Reserves/ReserveSlip.t index 9b28179fcc..cd7a1936b4 100644 --- a/t/db_dependent/Reserves/ReserveSlip.t +++ b/t/db_dependent/Reserves/ReserveSlip.t @@ -19,7 +19,7 @@ use Modern::Perl; -use Test::More tests => 5; +use Test::More tests => 3; use t::lib::TestBuilder; use C4::Reserves qw( ReserveSlip ); @@ -118,48 +118,16 @@ my $letter = $builder->build( is ( ReserveSlip(), undef, "No hold slip returned if invalid or undef borrowernumber and/or biblionumber" ); is ( ReserveSlip({ branchcode => $library->{branchcode}, - borrowernumber => $patron->{borrowernumber}, - biblionumber => $biblio->{biblionumber}, + reserve_id => $hold1->reserve_id, })->{code}, 'HOLD_SLIP', "Get a hold slip from library, patron and biblio" ); is (ReserveSlip({ branchcode => $library->{branchcode}, - borrowernumber => $patron->{borrowernumber}, - biblionumber => $biblio->{biblionumber}, + reserve_id => $hold1->reserve_id, })->{content}, "Hold found for $patron->{firstname}: Please pick up $biblio->{title} with barcode $item1->{barcode} at $library->{branchcode}.", "Hold slip contains correctly parsed content"); -is_deeply( - ReserveSlip({ - branchcode => $library->{branchcode}, - borrowernumber => $patron->{borrowernumber}, - biblionumber => $biblio->{biblionumber}, - }), - ReserveSlip({ - branchcode => $library->{branchcode}, - borrowernumber => $patron->{borrowernumber}, - biblionumber => $biblio->{biblionumber}, - itemnumber => $item1->{itemnumber}, - barcode => $item1->{barcode}, - }), - "No item as param generate hold slip from first item in reserves"); - -isnt ( - ReserveSlip({ - branchcode => $library->{branchcode}, - borrowernumber => $patron->{borrowernumber}, - biblionumber => $biblio->{biblionumber}, - })->{content}, - ReserveSlip({ - branchcode => $library->{branchcode}, - borrowernumber => $patron->{borrowernumber}, - biblionumber => $biblio->{biblionumber}, - itemnumber => $item2->{itemnumber}, - barcode => $item2->{barcode}, - })->{content}, - "Item and/or barcode as params return correct pickup item in hold slip"); - $schema->storage->txn_rollback; 1; -- 2.20.1