From 5c4db6bb11146c5fb213c55c88663aacd5a61127 Mon Sep 17 00:00:00 2001 From: Petro Vashchuk Date: Fri, 22 May 2020 18:11:28 +0300 Subject: [PATCH] Bug 25587: fix for "clear" button to reset all selects Button "clear" on cgi-bin/koha/admin/smart-rules.pl did not reset fields with a dropdown selector except the first one. This happens because jQuery selector .find("select option:first") in koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt selects only single first element in the whole group, as from jquery doc: > The :first pseudo-class is equivalent to :eq( 0 ). It could also be written as :lt( 1 ). While this matches only a single element, :first-child can match more than one: One for each parent. (https://api.jquery.com/first-selector/) And it works if replaced by: .find("select option:first-child") --- koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt index 5ae3bb94e1..61f36a1788 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt @@ -941,7 +941,7 @@ } }); $(edit_row).find("select").prop('disabled', false); - $(edit_row).find("select option:first").attr("selected", "selected"); + $(edit_row).find("select option:first-child").attr("selected", "selected"); $(edit_row).find("td:last input[name='clear']").remove(); } -- 2.17.1