Bugzilla – Attachment 105342 Details for
Bug 25556
Holds blocked when empty holdallowed value present in circulation_rules
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 25556: fix for unnecessary empty name/value pairs creation
Bug-25556-fix-for-unnecessary-empty-namevalue-pair.patch (text/plain), 3.11 KB, created by
Victor Grousset/tuxayo
on 2020-05-26 04:20:40 UTC
(
hide
)
Description:
Bug 25556: fix for unnecessary empty name/value pairs creation
Filename:
MIME Type:
Creator:
Victor Grousset/tuxayo
Created:
2020-05-26 04:20:40 UTC
Size:
3.11 KB
patch
obsolete
>From a2c7590de5bead4af95b7d1e100f6df29966ef97 Mon Sep 17 00:00:00 2001 >From: Petro Vashchuk <stalkernoid@gmail.com> >Date: Mon, 25 May 2020 17:39:58 +0300 >Subject: [PATCH] Bug 25556: fix for unnecessary empty name/value pairs > creation > >During the web-install onboarding process, when the default circulation rule gets created, "circulation_rules" table gets populated with empty rule_name/rule_value items. This behavior differs from how the "unset" button on the smart-rules.pl page in "Default checkout, hold and return policy" group acts and leads to unpredictable bug when empty "holdallowed" rule_name prevents holds from any user. >This fix removes creation of these empty name/value pairs. > >To reproduce: > 1) Start with an empty installation (or delete all circulation rules and press "unset" in hold and return policy section on /cgi-bin/koha/admin/smart-rules.pl page). This is to have the circulation_rules table empty so onboarding.pl will work. > 2) Go through the onboarding.pl process and create a default circulation rule. > 3) Make sure that circulation_rules table contains will contain empty "patron_maxonsiteissueqty", "max_holds", "patron_maxissueqty", "returnbranch", "holdallowed" and "hold_fulfillment_policy" fields. > 4) Apply the patch. > 5) Repeat steps 1 and 2. > 6) Observe that there are none of six mentioned above name/value pairs appeared. > >To reproduce the bug with empty "holdallowed" rule_name: > 1) Repeat steps 1, 2 and 3 that are listed in the previous instruction of reproduction, in order to get empty "holdallowed" field. > 2) Find existing or create a new book with available status and place a holding on it. > 3) Observe the yellow notification window with "Cannot place hold. No items are available to be placed on hold." warning. > 4) Apply the patch. > 5) Repeat steps 1 and 2. > 6) Observe that hold was successfully placed and yellow notification does not appear anymore. > >Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> >--- > installer/onboarding.pl | 22 ---------------------- > 1 file changed, 22 deletions(-) > >diff --git a/installer/onboarding.pl b/installer/onboarding.pl >index 547df29e0d..5d10d23c11 100755 >--- a/installer/onboarding.pl >+++ b/installer/onboarding.pl >@@ -286,30 +286,8 @@ if ( $step == 5 ) { > } > }; > >- my $params_2 = { >- branchcode => $branchcode, >- categorycode => $categorycode, >- rules => { >- patron_maxissueqty => "", >- patron_maxonsiteissueqty => "", >- max_holds => "", >- } >- }; >- >- my $params_3 = { >- branchcode => $branchcode, >- itemtype => $itemtype, >- rules => { >- holdallowed => "", >- hold_fulfillment_policy => "", >- returnbranch => "", >- } >- }; >- > eval { > Koha::CirculationRules->set_rules($params); >- Koha::CirculationRules->set_rules($params_2); >- Koha::CirculationRules->set_rules($params_3); > }; > > if ($@) { >-- >2.26.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 25556
:
105325
|
105342
|
105347