Bugzilla – Attachment 10537 Details for
Bug 8323
User created lists not sorting properly
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] bug 8323 fixing year sorting of a list
SIGNED-OFF-bug-8323-fixing-year-sorting-of-a-list.patch (text/plain), 1.65 KB, created by
Marc Véron
on 2012-06-27 09:41:16 UTC
(
hide
)
Description:
[SIGNED-OFF] bug 8323 fixing year sorting of a list
Filename:
MIME Type:
Creator:
Marc Véron
Created:
2012-06-27 09:41:16 UTC
Size:
1.65 KB
patch
obsolete
>From 5916621f948958c409878ec326fa4b9a2e53d7ce Mon Sep 17 00:00:00 2001 >From: Chris Hall <chrish@catalyst.net.nz> >Date: Fri, 22 Jun 2012 10:36:45 +1200 >Subject: [PATCH] [SIGNED-OFF] bug 8323 fixing year sorting of a list >Content-Type: text/plain; charset="utf-8" > >Signed-off-by: Marc Veron <veron@veron.ch> > >Works as expected. > >Caveat: If you edit the list in Opac, change the sort and then klick 'Save', >the List always is displayed in title order. This is du to the fact that >save calls opac-shelves.pl?viewshelf=4 without the sort parameter (defaults >to 'title'). >If you go back to lists, choose the list from List name, the param is >correct and the list displays in expected order. > >It took quite a time to track that down, I first thought that opac-shelves.pl >was broken. > >However, current bug 8323 is not affected, signing off. > >Marc >--- > C4/VirtualShelves/Page.pm | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > >diff --git a/C4/VirtualShelves/Page.pm b/C4/VirtualShelves/Page.pm >index f21fd85..c765cf0 100644 >--- a/C4/VirtualShelves/Page.pm >+++ b/C4/VirtualShelves/Page.pm >@@ -258,7 +258,7 @@ sub shelfpage { > if ( $sortfield eq 'year' ) { > $yearsort = 'year'; > } >- ( $items, $totitems ) = GetShelfContents( $shelfnumber, $shelflimit, $shelfoffset ); >+ ( $items, $totitems ) = GetShelfContents( $shelfnumber, $shelflimit, $shelfoffset, $sortfield eq 'year' ? 'copyrightdate' : $sortfield ); > for my $this_item (@$items) { > my $biblionumber = $this_item->{'biblionumber'}; > my $record = GetMarcBiblio($biblionumber); >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 8323
:
10530
| 10537